Indexation - #23
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the surgical episode-attachment logic so surgeries are attributed to diagnosis episodes via explicit Episode_Event links (instead of date-window matching), and bumps the package version to 0.5.3.
Changes:
- Switch SurgicalProcedure episode attribution from person+date-window joins to
Episode_Event-driven joins. - Bump project version to
0.5.3and sync lockfile metadata. - Add a
0.5.3changelog entry describing the new linkage behavior.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/omop_constructs/alchemy/episodes/surgical_joins.py |
Replaces date-window surgery attribution with Episode_Event-based linkage while preserving the outer-join “absence rule” shape. |
pyproject.toml |
Bumps project version to 0.5.3. |
uv.lock |
Updates locked editable package version and adjusts pexpect → ptyprocess marker metadata. |
CHANGELOG.md |
Adds release notes for 0.5.3 describing the surgery/episode join behavior change. |
Comments suppressed due to low confidence (1)
CHANGELOG.md:198
- The 0.5.3 changelog entry is a bit unclear/grammatically awkward (“adding separate distinct handling…”). Consider rewriting it to clearly state the behavior change (Episode_Event-driven surgery attribution) and its impact.
- adding separate distinct handling for joining surgeries in with episodes when there is an explicit link to a specific diagnosis
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+197
to
+198
| ## 0.5.3 | ||
| - adding separate distinct handling for joining surgeries in with episodes when there is an explicit link to a specific diagnosis No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.