Skip to content

Initialize padded sort buffers before CUB sort #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SRO-SA wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initialize padded sort buffers before CUB sort #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions cujson/parse_json_lines.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,9 +945,22 @@ inline uint8_t * stage2_tokenizer( uint8_t* block_GPU,

uint8_t* out_string_open_close_8_GPU;
uint32_t* out_string_open_close_8_index_GPU; // it's going to store structural index, not real index
cudaMallocAsync(&out_string_open_close_8_GPU, (last_index_tokens_open_close + padding2) * sizeof(uint8_t),0);
cudaMallocAsync(&out_string_open_close_8_index_GPU, last_index_tokens_open_close * sizeof(uint32_t),0);

// Fixed: Initialize it to 0 before using it in the kernel to avoid undefined behavior.
cudaMallocAsync(&out_string_open_close_8_GPU,
(last_index_tokens_open_close + padding2) * sizeof(uint8_t),
0);
cudaMemsetAsync(out_string_open_close_8_GPU,
0,
(last_index_tokens_open_close + padding2) * sizeof(uint8_t),
0);

cudaMallocAsync(&out_string_open_close_8_index_GPU,
last_index_tokens_open_close * sizeof(uint32_t),
0);
cudaMemsetAsync(out_string_open_close_8_index_GPU,
0,
last_index_tokens_open_close * sizeof(uint32_t),
0);
// extractStructuralIdx(): extractStructuralIdx() + extractOpenCloseIdx()
extractStructuralIdx<<<numBlock, BLOCKSIZE>>>(acc_structural_cnt, // prefix sum set bits until each word of structural
acc_open_close_cnt, // prefix sum set bits until each word of open close
Expand Down Expand Up @@ -1061,8 +1074,10 @@ int32_t* stage3_parser(uint8_t* open_close_bitmap, int32_t** open_close_index_d,
// _______________STEP_1__(a)_________________
int32_t* res; // temporary result that will use in following
uint32_t* oc_1; // output
cudaMallocAsync(&oc_1, oc_cnt_32*sizeof(uint32_t), 0);

// Fixed: Allocate memory for oc_1 and initialize it to zero
cudaMallocAsync(&oc_1, oc_cnt_32 * sizeof(uint32_t), 0);
cudaMemsetAsync(oc_1, 0, oc_cnt_32 * sizeof(uint32_t), 0);

map_open_close<<<numBlock_open_close_32, BLOCKSIZE>>>( (uint32_t*) open_close_bitmap, oc_1, oc_cnt_32, oc_cnt);
cudaStreamSynchronize(0);

Expand Down
23 changes: 19 additions & 4 deletions cujson/parse_standard_json.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,9 +1319,22 @@ inline uint8_t * Tokenize( uint8_t* block_GPU,

uint8_t* out_string_open_close_8_GPU;
uint32_t* out_string_open_close_8_index_GPU; // it's going to store structural index, not real index
cudaMallocAsync(&out_string_open_close_8_GPU, (last_index_tokens_open_close + padding2) * sizeof(uint8_t),0);
cudaMallocAsync(&out_string_open_close_8_index_GPU, last_index_tokens_open_close * sizeof(uint32_t),0);

// Fixed: Initialize it to 0 before using it in the kernel to avoid undefined behavior.
cudaMallocAsync(&out_string_open_close_8_GPU,
(last_index_tokens_open_close + padding2) * sizeof(uint8_t),
0);
cudaMemsetAsync(out_string_open_close_8_GPU,
0,
(last_index_tokens_open_close + padding2) * sizeof(uint8_t),
0);

cudaMallocAsync(&out_string_open_close_8_index_GPU,
last_index_tokens_open_close * sizeof(uint32_t),
0);
cudaMemsetAsync(out_string_open_close_8_index_GPU,
0,
last_index_tokens_open_close * sizeof(uint32_t),
0);
// cout << "res size before remove copy: " << last_index_tokens_open_close << "\n";

// cudaEventRecord(start, 0);
Expand Down Expand Up @@ -1575,7 +1588,9 @@ int32_t* Parser(uint8_t* open_close_GPU, int32_t** open_close_index_d, int32_t*
int32_t* res; // temporary result that will use in following

uint32_t* oc_1; // output
cudaMallocAsync(&oc_1, oc_cnt_32*sizeof(uint32_t), 0);
// Fixed: Allocate memory for oc_1 on the device and initialize it to zero.
cudaMallocAsync(&oc_1, oc_cnt_32 * sizeof(uint32_t), 0);
cudaMemsetAsync(oc_1, 0, oc_cnt_32 * sizeof(uint32_t), 0);

depth_init_MathAPI<<<numBlock_open_close_32, BLOCKSIZE>>>( (uint32_t*) open_close_GPU, oc_1, oc_cnt_32, oc_cnt);
cudaStreamSynchronize(0);
Expand Down