Carry authored inline list-style through the transformer - #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An authored inline
list-styleis silently dropped.list-stylewas referenced zero times in the entire transformer source.Confirmed on a real build, calm-lantern's site footer:
margin,padding,font-sizeandcolormap to native attributes;display:gridandgapride the layout carrier.list-style:noneis gone entirely.User-visible: footer links render with bullets the design does not have, and a "Three steps, no mystery" list renders a stray
1.2.3.before each item. Authored inlinelist-styleusage across the seven-project corpus: 35.Class-rule
list-style:nonein a stylesheet already survives, so this is specifically the inline path.Fix
Carry authored
list-styleand its longhands (list-style-type,list-style-position,list-style-image) on the existing geometry carrier. No core block exposes list-marker styling as a block support, so unlike borders this legitimately belongs on the carrier rather than a native attribute. No!importantis introduced.Verification
composer test/composer test:unit: 107 assertions, 0 failures.trunkbaseline (md5 matches on both sides), baseline run at this branch's exact merge-base.list-styleis asserted unchanged, includingassets === [], so markers still render and no carrier is added.Verified end to end in a generated site: calm-lantern's footer bullets and the stray
1. 2. 3.are both gone.Notes
Release-gated. minimalistic-site-builder consumes this only after a tagged release and a constraint bump, the same sequence as #883 -> v0.4.20.