Skip to content

Carry authored inline list-style through the transformer - #884

Merged
borkweb merged 2 commits into
trunkfrom
fix/carry-list-style
Aug 17, 2026
Merged

Carry authored inline list-style through the transformer#884
borkweb merged 2 commits into
trunkfrom
fix/carry-list-style

Conversation

@borkweb

@borkweb borkweb commented Aug 17, 2026

Copy link
Copy Markdown
Member

Problem

An authored inline list-style is silently dropped. list-style was referenced zero times in the entire transformer source.

Confirmed on a real build, calm-lantern's site footer:

DESIGN:    <ul style="list-style:none;margin:0;padding:0;display:grid;gap:0.5rem;font-size:0.95rem;">
GENERATED: <ul style="color:...;margin-top:0;...;font-size:0.95rem" class="wp-block-list be-inline-geometry-... ...">

margin, padding, font-size and color map to native attributes; display:grid and gap ride the layout carrier. list-style:none is gone entirely.

User-visible: footer links render with bullets the design does not have, and a "Three steps, no mystery" list renders a stray 1. 2. 3. before each item. Authored inline list-style usage across the seven-project corpus: 35.

Class-rule list-style:none in a stylesheet already survives, so this is specifically the inline path.

Fix

Carry authored list-style and its longhands (list-style-type, list-style-position, list-style-image) on the existing geometry carrier. No core block exposes list-marker styling as a block support, so unlike borders this legitimately belongs on the carrier rather than a native attribute. No !important is introduced.

Verification

  • Test committed before the fix. At the test-only commit the suite fails 3/107; with the fix, 107 pass.
  • composer test / composer test:unit: 107 assertions, 0 failures.
  • Static parity: byte-identical to a freshly-run trunk baseline (md5 matches on both sides), baseline run at this branch's exact merge-base.
  • Zero parity fixtures edited.
  • A list with no authored list-style is asserted unchanged, including assets === [], so markers still render and no carrier is added.

Verified end to end in a generated site: calm-lantern's footer bullets and the stray 1. 2. 3. are both gone.

Notes

Release-gated. minimalistic-site-builder consumes this only after a tagged release and a constraint bump, the same sequence as #883 -> v0.4.20.

@borkweb
borkweb merged commit 007379f into trunk Aug 17, 2026
4 checks passed
@borkweb
borkweb deleted the fix/carry-list-style branch August 17, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant