test(e2e): run prover client.test.ts in CI#24399
Merged
Merged
Conversation
single-node/prover/client.test.ts ran in no CI job: prover/full has two dedicated lines and the whole prover/ folder is left out of the generic discovery globs, so client fell through the gap. Fold a loop over the rest of prover/ (currently just client) into both branches of the CI_FULL switch so it mirrors full exactly: real Barretenberg with the 16-CPU/96g budget under CI_FULL, fake proofs otherwise, with _real/_fake name suffixes. Fixes A-1301
spalladino
force-pushed
the
spl/a1301-prover-client-ci
branch
from
1354957 to
7774769
Compare
PhilWindle
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
single-node/prover/client.test.tsran in no CI job:prover/was excluded from the auto-discovery globs (sofull.test.ts, dispatched via bespoke lines, wouldn't run twice), andclienthad no dedicated line, so it fell through the gap. This wires it in.Changes
prover/intoprover/server/(full.test.ts, full pipeline) andprover/client/(client.test.ts, client-side proving slice), each globbed by its own loop.CI_FULL=1, fake (FAKE_PROOFS=1) otherwise.tests=()globs (**recursion +!(prover)exclusion) in place of the hand-maintained per-folder list.Resulting prover jobs
CI_FULL=1(real):single-node/prover/server/full_real(16 CPU / 96g / 20m) +single-node/prover/client/client_real(2 CPU / 4g / 10m)CI_FULL=0(fake):single-node/prover/server/full_fake+single-node/prover/client/client_faketest_cmdsoutput is otherwise identical tomerge-train/spartan-v5— no other test added, dropped, or double-counted.Fixes A-1301