{Service Connector} az containerapp connection create: Block command as Service Connector (preview) on Azure Container Apps has been retired#33723
Open
khkh-ms wants to merge 1 commit into
Conversation
…d as Service Connector (preview) on Azure Container Apps has been retired Service Connector (preview) on Azure Container Apps has been retired (see microsoft/azure-container-apps#1566). Block creating new connections for the containerapp source in validate_params and validate_kafka_params while keeping list/show/validate/delete/update and other source resources working.
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
jsntcy,
wangzelin007,
yanzhudd and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
This PR blocks creation of new Service Connector connections when the source is Azure Container Apps (az containerapp connection create …), reflecting that Service Connector (preview) on ACA has been retired, while leaving existing connection management commands intact.
Changes:
- Added a validator guard to fail fast for
containerappsource onconnection createwith a retirement message. - Wired the guard into the main parameter validation flows (including the Confluent Kafka-specific validator path).
- Documented the change in
HISTORY.rst.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/azure-cli/HISTORY.rst | Adds a release note announcing the az containerapp connection create block due to retirement. |
| src/azure-cli/azure/cli/command_modules/serviceconnector/_validators.py | Introduces and invokes a validator to block new ContainerApp-source connection creation with a retirement error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+86
to
+90
| if 'create' in cmd.name and get_source_resource_name(cmd) == RESOURCE.ContainerApp: | ||
| raise ValidationError( | ||
| "Service Connector (preview) on Azure Container Apps has been retired. " | ||
| "'az containerapp connection create' is no longer supported. " | ||
| "For more information, see https://github.com/microsoft/azure-container-apps/issues/1566.") |
Comment on lines
+86
to
+90
| if 'create' in cmd.name and get_source_resource_name(cmd) == RESOURCE.ContainerApp: | ||
| raise ValidationError( | ||
| "Service Connector (preview) on Azure Container Apps has been retired. " | ||
| "'az containerapp connection create' is no longer supported. " | ||
| "For more information, see https://github.com/microsoft/azure-container-apps/issues/1566.") |
Comment on lines
+945
to
+946
| block_retired_containerapp_connection_create(cmd) | ||
|
|
|
|
||
| **Service Connector** | ||
|
|
||
| * `az containerapp connection create`: Block the command as Service Connector (preview) on Azure Container Apps has been retired (#38660284) |
Collaborator
|
Service Connector |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp connection createDescription
Service Connector (preview) on Azure Container Apps has been retired (see microsoft/azure-container-apps#1566). This change blocks creating new connections for the
containerappsource while keeping existing connections fully manageable.block_retired_containerapp_connection_createinserviceconnector/_validators.py, invoked at the top ofvalidate_paramsandvalidate_kafka_params. It raises aValidationErrorfor the ContainerApp source before any argument prompting, so the command fails fast with a clear retirement message instead of prompting for parameters.az containerapp connection create <target>(all targets, includingconfluent-cloud) now exits non-zero with:list,show,validate,delete, andupdateremain functional so users can still manage existing connections.Testing Guide
Built the CLI from source with
azdevand verified:az containerapp connection create postgresandaz containerapp connection create confluent-cloud ...→ retirement error, exit code 1, no prompting.az containerapp connection update/list/show/delete/validate→ work as before.az webapp connection create postgres→ unaffected (other sources still allow create).Work item: 38660284 (Remove Service Connector on ACA)