Remove dead CODEOWNERS rule for non-existent natgateway module#33735
Open
kobihikri wants to merge 1 commit into
Open
Remove dead CODEOWNERS rule for non-existent natgateway module#33735kobihikri wants to merge 1 commit into
kobihikri wants to merge 1 commit into
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @kobihikri! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up repository hygiene by removing a stale .github/CODEOWNERS entry that targets a command module directory (natgateway/) which no longer exists, ensuring CODEOWNERS routing remains accurate and non-misleading.
Changes:
- Remove the dead CODEOWNERS rule for
command_modules/natgateway/. - Rely on the existing
command_modules/network/rule (same owning team) for reviewer assignment going forward.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Remove dead CODEOWNERS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and thank you for azure-cli.
Tiny repo-hygiene cleanup:
.github/CODEOWNERSline 59 assignsbut that directory no longer exists at HEAD (
gh api repos/Azure/azure-cli/contents/src/azure-cli/azure/cli/command_modules/natgateway?ref=8d2615f9…→ 404; the module listing contains onlynetwork, where nat-gateway commands now live). The rule matches nothing, so it silently assigns no reviewers.This PR removes the one dead line. No coverage is lost — the very next line already routes
command_modules/network/to the same team.For transparency: I used AI assistance to spot and draft this; I verified the 404 and the surviving
network/rule myself.