Add E2E regression test for GET/HEAD requests with a body (#458) - #101
Open
swapnil-nagar wants to merge 1 commit into
Open
Add E2E regression test for GET/HEAD requests with a body (#458)#101swapnil-nagar wants to merge 1 commit into
swapnil-nagar wants to merge 1 commit into
Conversation
|
If this is a regression test, consider adding it to Watchtower as well? |
Contributor
Author
Sure, I will add test to that as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an end-to-end regression test that sends GET and HEAD requests carrying a body — via the raw http module, since node-fetch refuses GET/HEAD bodies — and asserts the request reaches the handler (status 200) instead of crashing the worker. Extends the shared helloWorld function to accept HEAD (v4 helloWorld.ts and v3 function.json so the test runs across all model configs, notably the non-streaming v4-oldConfig path where #458 reproduced.