Fix GET/HEAD request bodies failing before the handler - #461
Merged
Conversation
swapnil-nagar
enabled auto-merge (squash)
July 27, 2026 18:06
hallvictoria
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #458
Aligns the HttpRequest constructor with the existing streaming path by omitting the request body for GET/HEAD methods, so the worker no longer crashes constructing Node's global WHATWG Request (which rejects bodies on GET/HEAD). Fixes #458. Also omits the response body for null-body statuses (204/205/304) in HttpResponse to avoid the equivalent Response TypeError. Adds unit tests covering GET/HEAD body handling (incl. mixed-case methods) and null-body status responses.