Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Core/Services/OpenAPI/OpenApiDocumentor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1422,7 +1422,10 @@ private static OpenApiSchema CreateSpRequestComponentSchema(Dictionary<string, P
Default = def.Default is not null ? new OpenApiString(def.Default) : null
});

if (def.Required == true)
// A parameter is required when it is explicitly marked required in the runtime config,
// or when no default value is available, in which case a value must be provided in the
// request body. This mirrors the logic used by IsRequestBodyRequired.
if (def.Required ?? !def.HasConfigDefault)
{
required.Add(parameter);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@ public void ValidateRequestBodyContents(string entityName, string[] expectedPara
string expectedSchemaReferenceId = $"{entityName}{OpenApiDocumentor.SP_REQUEST_SUFFIX}";

ValidateOpenApiReferenceContents(schemaComponentReference, expectedSchemaReferenceId, expectedParameters, expectedParametersJsonTypes);

// Validate that parameters without a default value are marked as required in the schema component.
ISet<string> requiredParameters = _openApiDocument.Components.Schemas[expectedSchemaReferenceId].Required;
CollectionAssert.AreEquivalent(
expectedParameters,
requiredParameters.ToArray(),
message: "Unexpected required parameters in request body schema component.");
}
}

Expand Down