-
Notifications
You must be signed in to change notification settings - Fork 2
VAPI-3437 Add <Refer> BXML verb #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stampercasey
wants to merge
5
commits into
main
Choose a base branch
from
VAPI-3437
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−3
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5203568
VAPI-3437 Add <Refer> BXML verb, reusing shared SipUri type
stampercasey 3b462b1
chore: trigger no-mistakes gate
stampercasey 4fe6c5e
no-mistakes(document): fix broken links in new Refer verb docs
stampercasey 0ad38b6
update model and test
ckoegel f041ff4
VAPI-3437 delete refer.md and update sipuri docs
stampercasey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| using System; | ||
| using System.IO; | ||
| using System.Xml.Serialization; | ||
| using Bandwidth.Standard.Model.Bxml; | ||
| using Bandwidth.Standard.Model.Bxml.Verbs; | ||
| using Xunit; | ||
|
|
||
| namespace Bandwidth.Standard.Test.Unit.Model.Bxml | ||
| { | ||
| public class TestRefer | ||
| { | ||
| [Fact] | ||
| public void ReferTest() | ||
| { | ||
| var expected = "<?xml version=\"1.0\" encoding=\"utf-8\"?><Response> <Refer referCompleteUrl=\"https://example.com/handleRefer\" referCompleteMethod=\"POST\" tag=\"refer-tag\"> <SipUri>sip:alice@atlanta.example.com</SipUri> </Refer></Response>"; | ||
|
|
||
| var sipUri = new SipUri { Uri = "sip:alice@atlanta.example.com" }; | ||
|
|
||
| var refer = new Refer | ||
| { | ||
| SipUri = sipUri, | ||
| ReferCompleteUrl = "https://example.com/handleRefer", | ||
| ReferCompleteMethod = "POST", | ||
| Tag = "refer-tag" | ||
| }; | ||
|
|
||
| var actual = new Response(refer).ToBXML(); | ||
| Assert.Equal(expected, actual.Replace("\n", "").Replace("\r", "")); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| using Bandwidth.Standard.Model.Bxml; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Xml.Serialization; | ||
|
|
||
| namespace Bandwidth.Standard.Model.Bxml.Verbs | ||
| { | ||
| /// <summary> | ||
| /// The Refer verb is used to hand off a call to a SIP endpoint. | ||
| /// <para><seealso href="https://dev.bandwidth.com/docs/voice/bxml/refer"/></para> | ||
| /// </summary> | ||
| public class Refer : IVerb | ||
| { | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the Refer class with defaults. | ||
| /// </summary> | ||
| public Refer() | ||
| { | ||
| ReferCompleteMethod = "POST"; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// URL to receive the refer complete callback. | ||
| /// </summary> | ||
| [XmlAttribute("referCompleteUrl")] | ||
| public string ReferCompleteUrl { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// HTTP method to send the refer complete callback. GET or POST. Default value is POST. | ||
| /// </summary> | ||
| [XmlAttribute("referCompleteMethod")] | ||
| public string ReferCompleteMethod { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Optional custom string to include in callbacks. | ||
| /// </summary> | ||
| [XmlAttribute("tag")] | ||
| public string Tag { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// A SIP URI specifying the refer destination | ||
| /// </summary> | ||
| [XmlElement("SipUri")] | ||
| public SipUri SipUri { get; set; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This model got a bit over-engineered. I'm gonna make some changes on the branch to make it more closely align to our other verbs, but for reference:
WithFieldNamemethods, these are unnecessary for constructing the verb and add bloat to the model