Skip to content

Fix the #31 slug delegation: it was a silent no-op without transliterate: true #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the #31 slug delegation: it was a silent no-op without transliterate: true #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/phoenix_kit_document_creator/schemas/template.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ defmodule PhoenixKitDocumentCreator.Schemas.Template do
# Core's rule, not a local copy. The pipeline this replaced deleted every
# non-ASCII character, so a Cyrillic or Greek name produced an EMPTY slug and
# German lost its umlauts. Slug.slugify/2 romanizes instead.
defp slugify(name), do: Slug.slugify(name)
defp slugify(name), do: Slug.slugify(name, transliterate: true)

@doc "Changeset for upserting from Google Drive sync data."
def sync_changeset(template, attrs) do
Expand Down