Skip to content

Fix dynamic rulebook example#63

Open
dfremont wants to merge 1 commit into
v3from
dfremont-v3
Open

Fix dynamic rulebook example#63
dfremont wants to merge 1 commit into
v3from
dfremont-v3

Conversation

@dfremont

Copy link
Copy Markdown
Collaborator

No description provided.

@dfremont dfremont requested a review from kevinchang73 May 13, 2026 17:34
@kevinchang73

Copy link
Copy Markdown

Hi @dfremont, I ran into the following error while executing run_multi_dynamic.sh:

AttributeError: 'LateFeatureSampler' object has no attribute 'nextSample'. Did you mean: 'getSample'?

It looks like there's an API mismatch between VerifAI and Scenic. Specifically, verifai.samplers.feature_sampler.LateFeatureSampler uses getSample(), but scenic.core.external_params.VerifaiSampler is calling nextSample().

@dfremont

dfremont commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Hi Kai-Chun, that error indicates that you're using an old version of Scenic. Can you please try installing the latest version (3.1.1) and see if that fixes the problem? If so, I'll update pyproject.toml to require that version (I think I'd held off before because I hadn't yet made a new Scenic release).

@kevinchang73

kevinchang73 commented Jul 1, 2026

Copy link
Copy Markdown

Hi @dfremont, I installed the latest version of Scenic (3.1.1) using pip, but the issue still persists.
However, it does work correctly if I install it from source using the main branch of the GitHub repo. Is this expected?

@Eric-Vin

Eric-Vin commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Hi @kevinchang73, this is expected, as the API changes I made for VerifAI 3.0 were after the last PyPi release of Scenic and so are only present on GitHub right now.

@kevinchang73 kevinchang73 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Then I'll approve the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants