chore: update to new pkgs.mango - #578
Open
ssoberun wants to merge 1 commit into
Open
Conversation
Author
|
it seems it has changed in unstable but not in 26.05, hence the check on ubuntu-latest failing |
AlexLov
reviewed
Jul 24, 2026
|
|
||
| flags."-c" = config.configFile.path; | ||
| package = lib.mkDefault pkgs.mangowc; | ||
| package = lib.mkDefault pkgs.mango; |
Contributor
There was a problem hiding this comment.
I would suggest adding version check, something like this:
package = lib.mkDefault (if lib.versionAtLeast lib.version "26.11.20260629" then pkgs.mango else pkgs.mangowc);
(please apply formatting and/or move the condition to let..in block)
Note, I took the date from PR's merge date, so it might not be accurate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title, pkgs.mangowc no longer works on unstable(?)