Add firmware simulator v9.26.3#125
Merged
Merged
Conversation
benma
marked this pull request as ready for review
July 9, 2026 09:50
benma-agent
force-pushed
the
add-simulator-v9.26.3
branch
from
July 9, 2026 10:02
959d2a4 to
bad8c72
Compare
Collaborator
|
CI is failing @benma |
Remove redundant references in format arguments so the beta toolchain passes with warnings denied.
benma-agent
force-pushed
the
add-simulator-v9.26.3
branch
from
July 9, 2026 10:09
bad8c72 to
cdbe302
Compare
bznein
approved these changes
Jul 9, 2026
bznein
left a comment
bznein
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with the comment I left on another repo about the commit message No reset workaround was needed in this repo, as it has no simulator backup reset test.
Add the v9.26.3 BitBox02 simulator release to the simulator test data.
benma-agent
force-pushed
the
add-simulator-v9.26.3
branch
from
July 9, 2026 10:26
cdbe302 to
7a66634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
useless_borrows_in_formattingwarnings in EIP-712 and PSBT formatting.Tests: