feat(sdk-core): define EdDSA MPCv2 key gen callback types - #9194
Merged
Conversation
Contributor
bitgo-ai-agent-dev
Bot
force-pushed
the
wci-894-define-eddsa-mpcv2-keygen-callback-types
branch
from
July 7, 2026 12:11
17db4a4 to
c511afa
Compare
Add EddsaMPCv2KeyGenCallbacks interface and per-round callback type definitions to iWallets.ts, following the ECDSA MPCv2 pattern. Also define EddsaMPCv2SignedMessage (the PGP-signed DKG message type) and export all new types from index.ts. These types are the contract between the SDK orchestrator (createKeychainsWithExternalSigner, WCI-916) and external signer implementations (ME callback factory, WCI-895). Defining them first allows downstream tickets to reference a stable interface. Ticket: WCI-894 Session-Id: 5618dd06-6b18-4b4d-a0f3-4e8efd3271ca Task-Id: 51b30ada-7aea-4ec7-a83e-96900abaaeeb
bitgo-ai-agent-dev
Bot
force-pushed
the
wci-894-define-eddsa-mpcv2-keygen-callback-types
branch
2 times, most recently
from
July 7, 2026 13:36
3bacf25 to
248bbfd
Compare
Marzooqa
marked this pull request as ready for review
July 7, 2026 17:12
davidkaplanbitgo
approved these changes
Jul 7, 2026
davidkaplanbitgo
left a comment
davidkaplanbitgo
left a comment
Contributor
There was a problem hiding this comment.
LGTM - just interfaces that match the others
Marzooqa
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EddsaMPCv2SignedMessageinterface toiWallets.ts— the PGP-signed DKG message type ({ message: string; signature: string }) produced by Silence Labs MPS partiesEddsaMPCv2KeyGenInitializeCallback,EddsaMPCv2KeyGenRound1Callback,EddsaMPCv2KeyGenRound2Callback,EddsaMPCv2KeyGenFinalizeCallbackEddsaMPCv2KeyGenCallbacksinterface bundling all four callbacksmodules/sdk-core/src/index.tsWhy
createKeychainsWithExternalSigner, WCI-916) calls back into the external signer (ME/AWM) at each DKG roundEcdsaMPCv2KeyGenCallbacks, added in WCN-682 / PR feat: add external signer support for ECDSA and EdDSA TSS key generation #9128)Test plan
createKeychainsWithExternalSigner(WCI-916)Ticket: WCI-894