fix(statics): correct addressCoin for non-ETH L2 OFC tokens#9271
Merged
ArunBala-Bitgo merged 1 commit intoJul 16, 2026
Merged
Conversation
Contributor
bitgo-ai-agent-dev
Bot
force-pushed
the
cecho-1687-fix-addresscoin-for-non-eth-ofc-tokens
branch
from
July 16, 2026 07:43
de189a1 to
905ba62
Compare
shivabitgo
marked this pull request as ready for review
July 16, 2026 09:32
Several OFC tokens on non-ETH L2 chains (mantle, tmantle, megaeth, tmegaeth, seievm) were registered via ofcerc20()/tofcerc20() without explicitly passing addressCoin, so they inherited the default of 'eth'/'teth'. This caused wallet-platform to return ETH addresses instead of the correct chain addresses when listing addresses for these tokens on a Go Account wallet. Pass addressCoin explicitly for all 13 affected tokens: - ofcmantle: usdt, usdc, usde, usdt0, ausd, usd1 → 'mantle' - ofctmantle: bgerch, usd1, stgusd1 → 'tmantle' - ofcmegaeth: mega, weth → 'megaeth' - ofctmegaeth: tmt → 'tmegaeth' - ofcseievm: wsei → 'seievm' Also adds a regression test in ofcCoinParity.ts that asserts the correct addressCoin value for each affected token. Ticket: CECHO-1687 Session-Id: 8dce005c-d7ec-476e-a149-7810984c8663 Task-Id: 407369e3-531d-4ba2-9a6a-ced6a51639eb
ArunBala-Bitgo
force-pushed
the
cecho-1687-fix-addresscoin-for-non-eth-ofc-tokens
branch
from
July 16, 2026 09:54
905ba62 to
ec2d1ed
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect addressCoin metadata for a set of OFC ERC20 tokens on non-Ethereum EVM chains (Mantle, MegaEth, SeiEVM) that were previously inheriting the ofcerc20() / tofcerc20() default (eth / teth), which led downstream systems to return the wrong address type for those tokens.
Changes:
- Explicitly sets
addressCoinfor 13 affected OFC tokens across Mantle, Mantle testnet, MegaEth, MegaEth testnet, and SeiEVM. - Adds a unit test to validate
addressCoinconsistency for OFC token naming patterns. - Fixes a testnet Hoodeth token name to use the
ofct...prefix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/statics/src/coins/ofcErc20Coins.ts | Passes explicit addressCoin for the affected OFC tokens so address derivation maps to the correct chain coin instead of defaulting to eth/teth. |
| modules/statics/test/unit/ofcCoinParity.ts | Adds a regression test that validates addressCoin points to a real coin and matches the ofc{chain}:{token} naming convention. |
| modules/statics/src/coins/ofcHoodethTokens.ts | Corrects a tofcerc20 token name to use the ofcthoodeth:* prefix (testnet). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
addressCoinexplicitly for 13 OFC tokens that were inheriting the wrong default ('eth'/'teth') fromofcerc20()/tofcerc20():ofcmantle:usdt,ofcmantle:usdc,ofcmantle:usde,ofcmantle:usdt0,ofcmantle:ausd,ofcmantle:usd1→'mantle'ofctmantle:bgerch,ofctmantle:usd1,ofctmantle:stgusd1→'tmantle'ofcmegaeth:mega,ofcmegaeth:weth→'megaeth'ofctmegaeth:tmt→'tmegaeth'ofcseievm:wsei→'seievm'ofcCoinParity.tsasserting the correctaddressCoinfor each affected tokenWhy
ofcerc20()defaultsaddressCointo'eth'. Tokens on separate L2 chains (Mantle, MegaEth, SeiEVM) were omitting the argument and inheriting'eth'instead of their respective chain coin.GET /api/v2/ofc/wallet/:walletId/addresses?token=ofcmegaeth:megareturned ETH addresses instead of MegaEth addresses). Confirmed reproduced forofcmegaeth:mega.Test plan
tsc --noEmit)ofcCoinParity.ts,ofcTokenNaming.ts)addressCoinvalue for all 13 affected tokensTicket: CECHO-1687