Add keyframe format v1 CLI export - #565
Open
MuhammadBilalKhan267 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
save-keyframesCLI command that exports detected scene changes using keyframe format v1.The command supports custom filenames and output directories through CLI options and
scenedetect.cfg.Testing
Added CLI tests covering:
Known limitation
VFR inputs may produce incorrect frame numbers because cuts currently store timestamps and
FrameTimecode.frame_numderives a frame number using the average frame rate. Exact VFR frame ordinal support will be handled separately.Addresses #534