Skip to content

transcription: add dictionary and AI enhancement - #22

Merged
BumpyClock merged 17 commits into
mainfrom
feat/transcript-enhancement
Jul 16, 2026
Merged

transcription: add dictionary and AI enhancement#22
BumpyClock merged 17 commits into
mainfrom
feat/transcript-enhancement

Conversation

@BumpyClock

@BumpyClock BumpyClock commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Important

Stacked on #21. Merge #21 first, then retarget this PR to main.

Summary

  • add deterministic custom dictionary replacements, including whole-term C++, C#, and .NET handling, and Whisper vocabulary hints
  • add optional OpenAI-compatible enhancement through OpenAI, Ollama, or LM Studio
  • keep API keys in environment variables and redact provider bodies/transcripts from errors
  • reconcile enhanced final text with live preview and preserve deterministic fallback
  • add ASR real-time-factor telemetry and coalesce model warm-up work
  • require the installed Whisper sidecar manifest to match the app protocol and expose an update action for stale installs
  • expose settings UI and document provider trust boundaries and live-preview limits
  • ignore .pi-subagents/ and commit the approved Claude plugin settings

Security and reliability

  • OpenAI keys are read from the configured env var only
  • custom OpenAI base URLs receive that bearer key and must be trusted
  • every non-loopback provider endpoint requires HTTPS; loopback HTTP remains supported
  • credentials, queries, and fragments in provider base URLs are rejected
  • automatic redirects and system proxy discovery are disabled for AI enhancement requests
  • endpoint selection compares parsed hosts, not substrings
  • response bodies are streamed with a 1 MiB limit and transcript contents are excluded from parse/status errors
  • incomplete Chat Completions and Responses API payloads are rejected
  • provider-dependent model defaults survive persisted-settings deserialization
  • malformed persisted dictionary entries are dropped without resetting unrelated settings
  • transcription finalization blocks overlapping captures and cleans up trusted previews on model removal

Testing

  • cargo fmt --all -- --check
  • cargo check --workspace --all-targets --locked
  • cargo test --workspace --locked
  • cargo clippy --workspace --all-targets --locked -- --deny warnings

All checks pass on Rust 1.95, including the complete workspace test suite.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c700736f-c203-4e56-9d94-e0d9b07395d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/transcript-enhancement

Comment @coderabbitai help to get the list of available commands.

@BumpyClock

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@BumpyClock

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@BumpyClock

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@BumpyClock

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@BumpyClock

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@BumpyClock
BumpyClock changed the base branch from fix/gpui-sidebar-toolchain to main July 16, 2026 23:10
@BumpyClock
BumpyClock merged commit a42aa13 into main Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant