feat(audio): allow lazy loading of AUDO chunk#326
Open
cobaltgit wants to merge 4 commits into
Open
Conversation
cobaltgit
marked this pull request as ready for review
July 17, 2026 15:07
Collaborator
|
Where does the mmap audio groups thing happen? I can't see it. Am I a stupid illiterate chud who can't read code? |
Collaborator
Author
|
The audio groups are data.wins here so we just pass the MAP_FILE mode to the parse options |
Collaborator
Author
|
Well not sure what OpenAL does now so |
Collaborator
|
Could you seperate the mmap audio groups thing into its own patch? I wanna see how much memory that saves on it's own. |
…eparate PR to investigate memory savings)
cobaltgit
changed the title
Collaborator
Author
cobaltgit
changed the title
cobaltgit
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
largely based on what that one Vita port is doing with the OpenAL backend, useful for platforms like the Vita that can't mmap the way POSIX and Win32 do
Also mmapping the audio groups (
audiogroup*.dat) slightly saves memory