Fix pre-commit script not preventing commit - #167
Open
alitzel-macias wants to merge 2 commits into
Open
Conversation
Contributor
|
Nice. thank you! Maybe you could add a comment or note explaining why the status is needed, so the people doing the course don't get confused. Note Another option to fix this would be to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Exercise 7, in the pre-commit script when the whitespace check script failed but the verify-name-and-email script didn't, then pre-commit exited without error and allowed the commit to go through.