Skip to content

Repair issues in 'Reports' generation.#224

Open
henri62 wants to merge 1 commit into
CANopenNode:mainfrom
henri62:bugfix/reports
Open

Repair issues in 'Reports' generation.#224
henri62 wants to merge 1 commit into
CANopenNode:mainfrom
henri62:bugfix/reports

Conversation

@henri62

@henri62 henri62 commented Jun 19, 2026

Copy link
Copy Markdown

Fixes:

  1. Fix an exception in the code when an non-existing subindex is referenced in a TPDO. See Unhandled exception running "Reports->Network PDO". #222 for details and reproduction.

  2. Fix an error when Reports->Documentation is called and you have spaces in your windows profile.

  3. Tested with a file that has a mapping to a non-existing sub-index, it now reports this error in the generated report with a RED colored message (via a style sheet ref) that the subindex is missing. To my opinion no error pop-up or something is needed because the goal is to make a report, so it suits the purpose.

  4. When you have a userprofile that contains spaces the generated temp file path for the *.md file also contains spaces and the viewer pop-up did not show up but gave an error of a missing file. The file is now quoted and the call is "modernized".

I have read the contributing guidelines, I agree to following them and I agree to the Developer's Certificate of Origin 1.1

@nimrof

nimrof commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Hi @henri62,
Sorry for the late reply.

I am unable to replicate the report generation problem with the file that is attached when using git master.
Could you check if the attached file causes the problem or if i am doing something wrong when trying to reproduce?

Recording.2026-07-25.115941.mp4

@nimrof nimrof added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Jul 25, 2026
@henri62

henri62 commented Jul 25, 2026

Copy link
Copy Markdown
Author

That's strange, maybe I accidentally attached the (xdd) file where I fixed the issue already. Unfortunately our company just started the 3 weeks holiday so I cannot check if the file I attached here breaks the code. You have to wait for about 2 weeks, then I can test it. (And if it doesnt reproduce create the file again)

I tried to manually view the file to see if it should reproduce it but cannot see it. So please wait.

On june 17th, I reported to root cause of the problem in the original ticket #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants