split challenge.py into class based properties#217
Open
vellvoid wants to merge 4 commits into
Open
Conversation
Port the two master-side changes into the property abstraction: - scheduled_at (be1f386) becomes ScheduledAtProperty in properties/scalars.py, registered between next and module to preserve the spec key order. The parse/normalize/compare helpers move off Challenge onto the property as parse()/normalize()/matches(). Validation needed a new home, so Property gains a lint() hook that lint_challenge() dispatches over the registry - keeping "one new attribute = one Property subclass + one registry entry". - Modules are now always referenced by name (fc6d6f0). The remote version of the ctfd modules commit was newer than the local 4bf240e the refactor was built on, so ModuleProperty._set/matches still carried the older module-by-id semantics; both are updated to coerce numeric names to strings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.