Slugify the branch name used as the docker image tag#2066
Merged
Conversation
The Build Docker job tags the image with the branch name, so any branch with a slash in it fails the build: ERROR: failed to build: invalid tag "ghcr.io/cadquery/cadquery-docker:fix/assembly-load-segfault": invalid reference Replace the slashes for the tag. On master the tag is unchanged, so the published image keeps its name.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 30 30
Lines 9435 9435
Branches 1405 1405
=======================================
Hits 9038 9038
Misses 242 242
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adam-urbanczyk
approved these changes
Jul 13, 2026
adam-urbanczyk
left a comment
Member
There was a problem hiding this comment.
Thanks @HaozheZhang6, LGTM.
Member
|
CI fix, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Build Docker job tags the image with the raw branch name:
A docker tag cannot contain a slash, so any PR from a branch named like
fix/...ordocs/...fails the build before it even starts:That is currently red on #2064, #2065 and #2044.
This replaces the slashes when building the tag.
masterhas none, so the tag pushed to GHCR is unchanged.This branch has a slash in its own name, so the Build Docker job on this PR is the check.