Remove fabricated strength-scan diagnostics and enforce data integrity#24
Open
charlesmartin14 wants to merge 1 commit into
Open
Remove fabricated strength-scan diagnostics and enforce data integrity#24charlesmartin14 wants to merge 1 commit into
charlesmartin14 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
weightwatcher_detailsimmediately before projection and (whenimmediate_projection_spectralis true) once after the full projection; measured layer records are matched bylongname/nameand written towwpgd_projection_spectral.csvwith measured fields only. (src/wwgpt/train.py,src/wwgpt/ww.py)prepare_local_textfallback in productionrun_strength_scanand replaced it with a provenance-richRuntimeErrorthat includesrequested data root,level,token multiplier,expected directory, original exception type and message. (src/wwgpt/strength_scan.py)immediate_projection_spectral); incompatibilities are recorded append-only. (src/wwgpt/strength_scan.py)immediate_spectral_source = "weightwatcher_measured",weightwatcher_version,weightwatcher_configuration, andmeasurement_valid_for_science = true; analysis rejects legacy files lacking these fields aslegacy_fabricated_or_unverifiedand emits prominent warnings. (src/wwgpt/strength_scan_analysis.py,src/wwgpt/train.py)wwgpt audit-strength-scan --scan-root PATHwhich writesanalysis/strength_scan_integrity_audit.csvandanalysis/strength_scan_integrity_summary.jsonand distinguishes Cases A/B/C (fabricated immediate alpha, fixture/toy budget, fully measured). (src/wwgpt/strength_scan_analysis.py,src/wwgpt/cli.py)notebooks/07_strength_scan_overview.ipynbandnotebooks/08_strength_scan_weightwatcher.ipynbnow refuse missing real scan roots by default and gate test-fixture usage behindWWGPT_ALLOW_TEST_FIXTURE=1, and immediate-alpha analysis refuses legacy/unverified files.docs/STRENGTH_SCAN_DATA_INTEGRITY.mdexplaining the prior issue and audit procedure.Testing
python -m pip install -e .successfully.pytest -qand all automated tests passed (42 passed, 3 warnings).wwgpt audit-strength-scanagainst three synthetic scan directories representing Cases A/B/C and confirmed the audit classifications:legacy_fabricated_or_unverifiedand immediate-alpha analysis invalid.python -m compileall src/wwgpt) and scanned repository for removed fabrication markers (no remaining hardcodedalpha_before = 2.5,D_before = 0.02,num_evals_before = 10,prepare_local_textfallback in production).All fabricated immediate-alpha generation and silent dataset fallbacks have been removed from production flows, immediate WeightWatcher before/after diagnostics are genuinely measured when enabled, and legacy fabricated immediate-alpha files are excluded from scientific alpha analysis unless re-measured.
Codex Task