Skip to content

Fixed the bug that crashes the program if no policy file was attached. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saaketh0 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fixed the bug that crashes the program if no policy file was attached. #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/helloworld/workflow/example_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "grpc_stubs"))

from deploy import deploy
from example_agent_stub import ExampleAgentStub
from example_agent import ExampleAgent


def main(name: str = "World"):
agent = ExampleAgentStub()
agent = ExampleAgent()
Comment on lines +18 to +22

@coderabbitai coderabbitai Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win

Update the greeting extraction for ExampleAgent.

ExampleAgent.hello() returns a str, but main still calls greeting.value() at Line 24. This causes an AttributeError for every invocation. Return greeting directly or adapt the workflow to the new return type.

Proposed fix 
-    return {"greeting": greeting.value()}
+    return {"greeting": greeting}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/helloworld/workflow/example_workflow.py` around lines 18 - 22,
Update main after calling ExampleAgent.hello() to treat its result as a string
and return or print greeting directly, removing the greeting.value() call while
preserving the existing workflow behavior.

greeting = agent.hello(name=name)
return {"greeting": greeting.value()}

Expand Down
2 changes: 1 addition & 1 deletion ventis/controller/global_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def _load_policy_rules(self):
logger.info(
"No policy file found at %s, skipping policy setup.", policy_path
)
return
return []

with open(policy_path, "r") as f:
policy_config = yaml.safe_load(f)
Expand Down
Loading