Support decision point display value search in experiment filters#3225
Open
zackcl wants to merge 2 commits into
Open
Support decision point display value search in experiment filters#3225zackcl wants to merge 2 commits into
zackcl wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves #3224 by extending experiment list search filtering so Decision Point queries can match the displayed site (target) format (while keeping the existing site-only and target-only matching), and by applying the same behavior to global (“all”) search.
Changes:
- Add a decision-point “display value” search clause:
sitewhen target is empty, otherwiseCONCAT(site, ' (', target, ')'). - Reuse the same decision-point search logic for both
DECISION_POINTfiltering andALLsearch. - Add unit tests covering the generated SQL clauses and update the paginated endpoint Swagger enum values.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/backend/src/api/services/ExperimentService.ts | Adds the combined decision-point display search clause and factors decision-point search terms into a shared helper. |
| packages/backend/test/unit/services/ExperimentService.test.ts | Adds unit tests verifying decision-point and all-search include the new display-value matching clause. |
| packages/backend/src/api/controllers/ExperimentController.ts | Updates Swagger docs to include additional supported search keys (context, id, decisionPoint). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danoswaltCL
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3224
Changes:
site (target)format