Skip to content

ChEBI IDs should always be strings - #176

Merged
sfluegel05 merged 1 commit into
devfrom
fix/id-matching
Jul 24, 2026
Merged

ChEBI IDs should always be strings#176
sfluegel05 merged 1 commit into
devfrom
fix/id-matching

Conversation

@sfluegel05

Copy link
Copy Markdown
Collaborator

ChEBI IDs should be treated as strings. However, pandas sees this differently and automatically assigns them to the integer datatype. This leads to issues down the line, e.g., when filtering into train/val/test:

    self._dynamic_df_train = df_data[df_data["ident"].isin(train_ids)]
    self._dynamic_df_val = df_data[df_data["ident"].isin(validation_ids)]
    self._dynamic_df_test = df_data[df_data["ident"].isin(test_ids)]

train_ids, validation_ids and test_ids are lists of strings, so the assignment fails if df_data contains integers.

@sfluegel05
sfluegel05 merged commit 3fd75e0 into dev Jul 24, 2026
4 checks passed
@sfluegel05
sfluegel05 deleted the fix/id-matching branch July 24, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant