Skip to content

Asymmetric Loss - #178

Open
tibrinkmann wants to merge 3 commits into
ChEB-AI:devfrom
tibrinkmann:dev
Open

Asymmetric Loss #178
tibrinkmann wants to merge 3 commits into
ChEB-AI:devfrom
tibrinkmann:dev

Conversation

@tibrinkmann

Copy link
Copy Markdown

ASL implementation and config file. Default values from original paper/implementation.
Best parameters in experiments: gamma_pos = gamma_neg = 0 and clip = 0.15

@sfluegel05

Copy link
Copy Markdown
Collaborator

Thanks for the PR. I adjusted the torch grad handling. In your implementation (and the original implementation), the gradient gets disabled and enabled globally. This means that if someone has disabled grad calculation outside of the ASL function, that will be overwritten. With the context, this doesn't happen.

Also, for some reason, the single-label variant doesn't use the disable-grad flag. I don't see why. @tibrinkmann did you test the ASL with and / or without the disabled gradient? That seems to be quite an important difference. Also, is there any reason not to use the optimized version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants