Skip to content

ci: validate pnpm override resolution - #3005

Open
lntutor wants to merge 2 commits into
Chainlit:mainfrom
lntutor:fix/pnpm-override-validation
Open

ci: validate pnpm override resolution#3005
lntutor wants to merge 2 commits into
Chainlit:mainfrom
lntutor:fix/pnpm-override-validation

Conversation

@lntutor

@lntutor lntutor commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary by cubic

Adds a CI check to validate that pnpm overrides are correctly applied across lockfiles, failing when resolved versions don’t match override targets. Now correctly handles selector semantics (including parent>dependency edges) to prevent drift.

  • New Features

    • Added scripts/check-pnpm-overrides.mjs to verify override targets across root and workspace lockfiles, with support for parent>dependency selectors and prerelease-aware matching; skips non-semver targets.
    • Added tests in scripts/check-pnpm-overrides.test.mjs.
    • New scripts: check-pnpm-overrides and test:check-pnpm-overrides.
    • CI workflow runs pnpm test:check-pnpm-overrides and pnpm check-pnpm-overrides.
  • Dependencies

    • Added semver and yaml.

Written for commit bca0187. Summary will update on new commits.

Review in cubic

Co-Authored-By: OpenAI Codex <noreply@openai.com>
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. dev-tooling Relating to developer/contributor toolings. labels Jul 31, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread scripts/check-pnpm-overrides.mjs Outdated
Comment thread scripts/check-pnpm-overrides.mjs Outdated
Comment thread package.json
Co-Authored-By: OpenAI Codex <noreply@openai.com>
@lntutor

lntutor commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Current head bca01879de29ef7807ff5ba76b3a1ba457266032 is mergeable and fully green. The three review findings on this PR are resolved on this exact head, and there are no unresolved review threads remaining. This looks ready for maintainer review when convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-tooling Relating to developer/contributor toolings. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant