fix(infra): drop backup_window so the RDS change can apply - #294
Merged
Conversation
terraform-apply failed on main after #293: InvalidParameterValue: The backup window and maintenance window must not overlap. `backup_retention_period = 0 -> 7` was the change that mattered — production had no point-in-time recovery. The `backup_window = "07:00-08:00"` next to it was an unnecessary timing tweak, and AWS assigns both the backup and maintenance windows without Terraform managing either, so pinning one guesses against the other. Dropping it. The windows AWS assigned already don't overlap, and a backup of a few MB on a db.t3.micro is seconds of I/O, so there was nothing to gain. If specific times are ever wanted, pin backup_window and maintenance_window together. The failed apply had already created aws_iam_role.ci_migrate before erroring; re-applying reconciles the rest, nothing needs manual cleanup. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Terraform Plan 📖
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terraform-applyfailed on main after #293 merged:Cause
My fault in #293.
backup_retention_period = 0 -> 7was the change that mattered — production had no point-in-time recovery at all. I bundledbackup_window = "07:00-08:00"next to it as a timing tweak nobody asked for.Terraform manages neither
backup_windownormaintenance_windowonbranch_rds— AWS assigned both. Pinning one guesses against the other, and AWS cross-validates them.Fix
Drop
backup_window. Keepbackup_retention_period = 7.The windows AWS assigned already don't overlap, and a backup of a few MB on a
db.t3.microis seconds of I/O, so there was nothing to gain. If specific times are ever wanted, pinbackup_windowandmaintenance_windowtogether.State
The failed apply was partial — it created
aws_iam_role.ci_migratebefore erroring on the RDS modify. Re-applying reconciles the remainder; nothing needs manual cleanup. Expect the plan here to show the RDS in-place update plus whateverci_migrateresources didn't land.Note PITR is still off in production until this applies, so the pre-migration snapshot in the
migratejob is currently the only rollback lever.terraform validateandfmtpass locally; I can't run a real plan (no credentials for account 489881683177), so the plan comment on this PR is the check that matters.🤖 Generated with Claude Code