feat(1061): graceful shutdown with configurable drain timeout - #1074
Open
abdoolyaro wants to merge 1 commit into
Open
feat(1061): graceful shutdown with configurable drain timeout#1074abdoolyaro wants to merge 1 commit into
abdoolyaro wants to merge 1 commit into
Conversation
- config: add SHUTDOWN_TIMEOUT_SECS (default 30s), validated > 0 - cache: add close() to CacheBackend/RedisCache (sends QUIT)/InMemoryCache (no-op) - main: handle SIGINT/SIGTERM, race in-flight drain against timeout via - tests: verify in-flight requests survive shutdown, and that a drain exceeding the timeout still terminates rather than hanging Closes CodeGirlsInc#1061
Contributor
|
@abdoolyaro is attempting to deploy a commit to the Mftee's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@abdoolyaro Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config: add SHUTDOWN_TIMEOUT_SECS (default 30s), validated > 0
cache: add close() to CacheBackend/RedisCache (sends QUIT)/InMemoryCache (no-op)
main: handle SIGINT/SIGTERM, race in-flight drain against timeout via
tests: verify in-flight requests survive shutdown, and that a drain
exceeding the timeout still terminates rather than hanging
Closes #1061