Skip to content

fix(DatePicker): a11y polish for weekday headers, label, and calendar…#3395

Draft
aresnik11 wants to merge 1 commit into
mainfrom
ajr-datepicker-polish-new
Draft

fix(DatePicker): a11y polish for weekday headers, label, and calendar…#3395
aresnik11 wants to merge 1 commit into
mainfrom
ajr-datepicker-polish-new

Conversation

@aresnik11

Copy link
Copy Markdown
Contributor

… button

  • Announce full weekday names in calendar headers instead of abbreviations
  • Associate the field label with the segment shell via aria-labelledby
  • Convert the presentational calendar icon to an IconButton with an openCalendarLabel translation

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to story X
  2. Do something
  3. Do that something in dark mode
  4. Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

… button

- Announce full weekday names in calendar headers instead of abbreviations
- Associate the field label with the segment shell via aria-labelledby
- Convert the presentational calendar icon to an IconButton with an
  openCalendarLabel translation

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nx-cloud

nx-cloud Bot commented Jul 7, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 81bac52


☁️ Nx Cloud last updated this comment at 2026-07-07 19:13:40 UTC

@nx-cloud

nx-cloud Bot commented Jul 7, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 81bac52


☁️ Nx Cloud last updated this comment at 2026-07-07 19:14:44 UTC

@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 72.2.3-alpha.500e59.0 npm diff
@codecademy/gamut-icons 9.57.10-alpha.500e59.0 npm diff
@codecademy/gamut-illustrations 0.58.16-alpha.500e59.0 npm diff
@codecademy/gamut-kit 3.0.7-alpha.500e59.0 npm diff
@codecademy/gamut-patterns 0.10.35-alpha.500e59.0 npm diff
@codecademy/gamut-styles 20.0.3-alpha.500e59.0 npm diff
@codecademy/gamut-tests 6.0.6-alpha.500e59.0 npm diff
@codecademy/variance 0.26.2-alpha.500e59.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.500e59.0 npm diff

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (b578661) to head (81bac52).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ges/gamut/src/DatePicker/DatePickerInput/index.tsx 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3395      +/-   ##
==========================================
- Coverage   90.55%   90.07%   -0.49%     
==========================================
  Files         398      270     -128     
  Lines        6586     5672     -914     
  Branches     2131     1910     -221     
==========================================
- Hits         5964     5109     -855     
+ Misses        613      554      -59     
  Partials        9        9              
Flag Coverage Δ
main ?
pull-request 90.07% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants