feat: individual settings to control user interaction#2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2666
Proposed changes
Splitup of the central
enableUserInteractioninto more fine grained options.enableSeekToClickcontrols whether a simple click scrubs the player to the beat at the clicked locationenablePlaybackRangeSelectioncontrols whether a click+drag draws a user selection which defines the selected playback range.resetPlaybackRangeOnClickcontrols whether a simple click clears the current selection. This is useful if a custom "clear" GUI button is shown. Allows the user to seek while keeping the selection.Edge cases:
Overall this allows a more static playback range selection control:
Checklist
Further details