feat(medcat-trainer): Speed up project upload#572
Open
mart-r wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to speed up project upload.
I was having trouble uploading the entity linking challenge project (i.e conversion from the raw linking challenge) to the app.cogstack.org trainer. It seemed to just crash it.
However, when I tried on the demo trainer (sites.er.kcl.ac.uk), it worked just fine.
So I thought perhaps the app.cogstack.org is timing out.
Looking at the timings, it looked like it was taking around 5m30s to upload the dataset to the the trainer instance I was running locally.
I got the time down to around half.
More specifically, it took 328.675s before, and with the changes it took 150.610s.
Here's the changes:
EDIT:
The next step would be to run this as a background task. But then some of the UI would need to also reflect that. So didn't get a chance to do that yet.