Skip to content

A bunch of changes - 0.8.9#55

Open
MausKaffee34767-2 wants to merge 8 commits into
Col-E:masterfrom
MausKaffee34767-2:0.8.9
Open

A bunch of changes - 0.8.9#55
MausKaffee34767-2 wants to merge 8 commits into
Col-E:masterfrom
MausKaffee34767-2:0.8.9

Conversation

@MausKaffee34767-2

Copy link
Copy Markdown

also upgrade gradle

…ready used org.json library, upgrade some dependencies
@Col-E Col-E added the enhancement New feature or request label May 29, 2026
@MausKaffee34767-2

Copy link
Copy Markdown
Author

Any plans to merge this?

@Col-E

Col-E commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Generally I intended to just make the next update a larger refactor given user feedback and feature requests, But yeah I can merge this since I've been putting that off. Sorry for the slow response 🙏

@MausKaffee34767-2

Copy link
Copy Markdown
Author

I could just also refactor code/add new features if you told me what you are planning

@MausKaffee34767-2 MausKaffee34767-2 changed the title Remove temporary JavaFX hack and upgrade dependencies and remove discontinued depedencies A bunch of changes - 0.8.9 Jul 3, 2026
@Col-E

Col-E commented Jul 4, 2026

Copy link
Copy Markdown
Owner
image image

The launcher targets Java 8 for maximum compatibility. It lets you run it on an older version while letting you still run Recaf with a new version. I'm going to revert some of the dependency updates here.

Comment thread core/build.gradle Outdated
@MausKaffee34767-2

MausKaffee34767-2 commented Jul 4, 2026

Copy link
Copy Markdown
Author

Builds and runs with:

openjdk version "1.8.0_492"
OpenJDK Runtime Environment (Temurin)(build 1.8.0_492-b09)
OpenJDK 64-Bit Server VM (Temurin)(build 25.492-b09, mixed mode)

@MausKaffee34767-2

Copy link
Copy Markdown
Author

I cant find any tests, even though junit is used

@Col-E

Col-E commented Jul 4, 2026

Copy link
Copy Markdown
Owner

There weren't any tests, but I just noticed the gradle build/sync failed with the version bump. Something to possibly address later.

@MausKaffee34767-2

MausKaffee34767-2 commented Jul 5, 2026

Copy link
Copy Markdown
Author

I'll look into it. Can you give me the exact error?

@MausKaffee34767-2

Copy link
Copy Markdown
Author

Build seems to work fine for me. As for "sync" i cant find any task called "sync"

@Col-E

Col-E commented Jul 5, 2026

Copy link
Copy Markdown
Owner

As for "sync" i cant find any task called "sync"

Sync is in reference to when you open the project in IntelliJ and it reads the properties of the project.

@MausKaffee34767-2

Copy link
Copy Markdown
Author

sync works fine for me with:

IntelliJ IDEA 2026.1.4
Build #IU-261.26222.65, built on July 2, 2026

Runtime version: 25.0.3+9-b329.124 amd64 (JCEF 137.0.17-261-b86)
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

What version are you using?

@MausKaffee34767-2

Copy link
Copy Markdown
Author

On java 8 compatibility: why does the recaf launcher have to support java 8 when the latest recaf dev build (github actions) requires java 21 (class version 65)

@Col-E

Col-E commented Jul 6, 2026

Copy link
Copy Markdown
Owner

From the prior post:

The launcher targets Java 8 for maximum compatibility. It lets you run it on an older version while letting you still run Recaf with a new version. I'm going to revert some of the dependency updates here.

Lots of people install Java on Windows with old versions and don't really update past it. Or, they'll install the new version without updating the PATH or .jar file extension association, so they run with an old version. The launcher will auto-detect installed versions of Java though and will pick an up-to-date one when it creates the Recaf process.

@MausKaffee34767-2

MausKaffee34767-2 commented Jul 7, 2026

Copy link
Copy Markdown
Author

I'll now dedicate some time to implementing various TODOs in the code.
Then I'll see if i can implement something which automatically downloads a compatible java version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants