Skip to content

[codex] Hosted review phase 1 foundation#1

Draft
romgenie wants to merge 4 commits into
codex/full-rust-cifrom
codex/hosted-review-phase-1
Draft

[codex] Hosted review phase 1 foundation#1
romgenie wants to merge 4 commits into
codex/full-rust-cifrom
codex/hosted-review-phase-1

Conversation

@romgenie

@romgenie romgenie commented Jul 5, 2026

Copy link
Copy Markdown

Hosted Review Phase 1 PR Notes

Linked issues

Fixes OpenCoven#97.
Fixes OpenCoven#100.

Summary

  • Adds trusted hosted-policy switches under hostedReview for user memory, managed rules, write tools, MCP servers, and plugins.
  • Wires prompt memory loading through the effective hosted policy so hosted review excludes global user memory and managed rules by default.
  • Keeps hosted review on read-only built-in tools by default and skips configured MCP/plugin loading unless explicitly allowed.
  • Documents the local-personal versus hosted-review defaults and trusted opt-ins.

Test evidence

  • cargo fmt --all
  • cargo check --workspace
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test -p claurst-core --lib hosted_review -- --nocapture
  • cargo test -p claurst --bin coven-code hosted_review -- --nocapture
  • cargo test --workspace progressed through unit tests, then failed in claurst --test acp_smoke because Windows Application Control blocked spawning the freshly built coven-code test binary with OS error 4551.

Risk notes

  • Local mode remains the default and keeps existing user/managed memory behavior.
  • Hosted deployments that need shared rules, write tools, MCP, or plugins must opt in explicitly through trusted hosted policy settings.

Fixes OpenCoven#97.

Fixes OpenCoven#100.

- gate hosted review memory scopes behind trusted policy settings

- default hosted review tools/MCP/plugins to restricted surfaces

- document Phase 1 behavior and add PR-ready test notes

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
@romgenie romgenie closed this Jul 5, 2026
@romgenie romgenie reopened this Jul 5, 2026
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
@romgenie romgenie changed the base branch from main to codex/full-rust-ci July 5, 2026 21:32
romgenie added 2 commits July 5, 2026 17:33
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>

# Conflicts:
#	src-rust/crates/core/src/claudemd.rs
#	src-rust/crates/tui/src/image_paste.rs
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
@romgenie

romgenie commented Jul 6, 2026

Copy link
Copy Markdown
Author

@coven-github dogfood smoke: inspect this draft PR and report whether the hosted-review phase 1 foundation looks ready for the next stacked phase. Do not publish changes.

@romgenie

romgenie commented Jul 6, 2026

Copy link
Copy Markdown
Author

@coven-github dogfood visible response test: inspect PR #1 at a high level and post your hosted result back to this PR. Do not modify files.

@covencat

covencat Bot commented Jul 6, 2026

Copy link
Copy Markdown

Cody dogfood result

Status: success

Cody made 0 commits across 0 files.

Cody

Completed the requested change.

Files changed

No files changed.

Files changed: 0
Commits: 0

Task f1c10c00-78cf-11f1-80ef-75436ae858b3. Publication is enabled on the hosted test adapter only.

@romgenie

romgenie commented Jul 6, 2026

Copy link
Copy Markdown
Author

@coven-github dogfood evidence test: review PR #1 using the supplied PR diff evidence. Cite the changed files you inspected. Do not modify files.

@romgenie

romgenie commented Jul 6, 2026

Copy link
Copy Markdown
Author

@coven-github dogfood evidence test 2: review PR #1 using the supplied PR diff evidence. Cite the changed files you inspected. Do not modify files.

@covencat

covencat Bot commented Jul 6, 2026

Copy link
Copy Markdown

Cody dogfood result

Status: success

Cody made 1 commit across 0 files.

Cody

Completed the requested change.

Files changed

No files changed.

Evidence

  • PR: [codex] Hosted review phase 1 foundation #1
  • Base: codex/full-rust-ci @ 66bf26b822119b0f2eda8cc0ea9143d12143a7e4
  • Head: codex/hosted-review-phase-1 @ 1d2af94708ab36f03cb08262c46c19d944967a72
  • Checked-out workspace HEAD: 1d2af94708ab36f03cb08262c46c19d944967a72
  • Changed files supplied to agent: 8
  • Review context SHA-256: e99a9af5375f6d0c7e56eb27b80aacff6c3eb54f4f53c2c8be97f1338824bb4d
  • Files: docs/advanced.md, docs/configuration.md, docs/shared/hosted-review-phase-1-pr.md, src-rust/crates/cli/src/main.rs, src-rust/crates/core/src/claudemd.rs, src-rust/crates/core/src/hosted_review.rs, src-rust/crates/core/src/lib.rs, src-rust/crates/core/src/session_storage.rs

Files changed: 0
Commits: 1

Task e66d9cf0-78d0-11f1-8ee5-93d1fecb95df. Publication is enabled on the hosted test adapter only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable global user memory in hosted review mode Add a hosted-mode memory isolation model

1 participant