Skip to content

[codex] Hosted review phase 2 identity and scoping#2

Draft
romgenie wants to merge 5 commits into
codex/hosted-review-phase-1from
codex/hosted-review-phase-2
Draft

[codex] Hosted review phase 2 identity and scoping#2
romgenie wants to merge 5 commits into
codex/hosted-review-phase-1from
codex/hosted-review-phase-2

Conversation

@romgenie

@romgenie romgenie commented Jul 5, 2026

Copy link
Copy Markdown

Hosted Review Phase 2 PR Notes

Linked issues

Fixes OpenCoven#98.
Fixes OpenCoven#99.
Fixes OpenCoven#104.
Fixes OpenCoven#110.

Summary

  • Expands hosted review scope to include tenant id, GitHub App installation id, stable repo id, repo full name, canonical repo identity, and memory domain.
  • Moves hosted memory and transcript paths from local-path identity to tenant/installation/repo/domain namespaces.
  • Adds canonical GitHub repo identity parsing for HTTPS and SSH remotes plus deterministic local project ids.
  • Adds hosted-derived settings sync project keys and hosted team-memory repo keys so hosted callers do not pass arbitrary project ids.
  • Splits hosted memory domains for default branch, branch, release, pull request, and security-private review contexts.
  • Hardens Windows test isolation for home-derived paths and gates Unix-socket daemon tests to Unix.
  • Corrects Windows TUI system-root test fixtures to use drive-qualified absolute paths.

Test evidence

  • cargo fmt --all
  • cargo check --workspace
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test -p claurst-core --lib hosted -- --nocapture
  • cargo test -p claurst-core --lib local_project_id -- --nocapture
  • cargo test -p claurst-core --lib sync_keys -- --nocapture
  • cargo test -p claurst-core --lib team_memory_key -- --nocapture
  • cargo test -p claurst-commands --lib named_commands::tests::test_agents_reset_removes_saved_roster_state -- --nocapture
  • cargo test -p claurst-core --lib roster_reset -- --nocapture
  • cargo test -p claurst-core --lib build_import_preview_maps_settings_and_doc -- --nocapture
  • cargo test -p claurst-core --lib test_imported_anthropic_cli_token_resolves_without_coven_oauth_client -- --nocapture
  • cargo test -p claurst-tui --lib windows_system_root --quiet
  • cargo test --workspace --quiet

Full-suite status

  • cargo test --workspace --quiet passes on Windows with CARGO_TARGET_DIR=C:\dev-cargo-target\coven-code after Smart App Control was disabled locally.

Risk notes

  • Local mode pathing remains available through existing local APIs.
  • Hosted durable state now requires explicit scope to avoid path-derived cross-tenant collisions.
  • Security-private domains are represented and are excluded from public review loading unless explicitly allowed by policy.

romgenie added 2 commits July 5, 2026 14:55
Fixes OpenCoven#98.

Fixes OpenCoven#99.

Fixes OpenCoven#104.

Fixes OpenCoven#110.

- add hosted tenant/installation/repo/domain scope types

- key hosted memory, transcripts, settings sync, and team memory by scoped identity

- add canonical repo parsing and Windows test isolation for home-derived paths

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
…enCoven#99 OpenCoven#104 OpenCoven#110)

Refs OpenCoven#98.
Refs OpenCoven#99.
Refs OpenCoven#104.
Refs OpenCoven#110.

- keep hosted identity/scoping tests portable on Windows
- preserve Phase 2 full-suite test coverage

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
@romgenie romgenie closed this Jul 5, 2026
@romgenie romgenie reopened this Jul 5, 2026
romgenie added 3 commits July 5, 2026 17:12
…hase-2

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
…hase-2

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>

# Conflicts:
#	src-rust/crates/commands/src/lib.rs
#	src-rust/crates/tui/src/app.rs
…hase-2

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant