[codex] Add bounded hosted review fix loop#2
Closed
romgenie wants to merge 23 commits into
Closed
Conversation
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Add a Mermaid flowchart to `ROADMAP.md` to show the build waves, issue dependencies, GTM tracks, and the critical path at a glance. Also ignore `.comux*` files so local comux artifacts do not get committed.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Connects the canonical coven-github docs to the TypeScript coven-github-webhook deployment bundle and its example policy.
Accepts degraded partial review results from coven-code while preserving complete clean-review validation. Aligns the v2 schemas and contract prose with coven-code PR #132. Refs OpenCoven#11 Refs PR OpenCoven#31 Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Return a structured 500 for missing webhook secret configuration and clarify nullable finding fields in the v2 contract docs. Refs PR OpenCoven#31 Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
* Update GitHub Sponsors username in FUNDING.yml * chore: trim funding config Signed-off-by: Val Alexander <bunsthedev@gmail.com> --------- Signed-off-by: Val Alexander <bunsthedev@gmail.com>
) * docs: add AGENTS.md + CLAUDE.md agent-contributor guidance Canonical entry point for AI agents opening PRs against the GitHub App adapter: the mandatory DCO sign-off (git commit -s), branch/PR workflow, local CI gates (cargo check/clippy -D warnings/test), adapter invariants (no App secrets, GitHub-native progress surfaces), and contributor attribution. Notes that a commit can carry both Signed-off-by and Co-authored-by trailers. CLAUDE.md points at AGENTS.md. Signed-off-by: Val Alexander <bunsthedev@gmail.com> * docs: clarify DCO signoff guidance Signed-off-by: Val Alexander <bunsthedev@gmail.com> --------- Signed-off-by: Val Alexander <bunsthedev@gmail.com>
romgenie
pushed a commit
that referenced
this pull request
Jul 8, 2026
…n#43) Proposes embedded SQLite (rusqlite, WAL) behind a new crates/store crate: persist-then-ack webhook handling keyed by X-GitHub-Delivery, a tasks table as the queue (atomic claims, startup recovery, supersession tombstones), task_attempts audit records, and Cave list continuity across restarts. Phased into three separately-mergeable PRs. Signed-off-by: Val Alexander <bunsthedev@gmail.com>
romgenie
pushed a commit
that referenced
this pull request
Jul 8, 2026
…tency (#2 phase 1) (OpenCoven#44) New crates/store crate: embedded SQLite (rusqlite, WAL, user_version migrations) holding webhook_deliveries, tasks, and task_attempts per docs/durable-task-store.md. The webhook route now records every delivery — and its routing outcome — atomically BEFORE GitHub hears success: - X-GitHub-Delivery is required (400 without it); it is the idempotency key - redelivered ids answer 200 {duplicate:true} and never dispatch twice - routed tasks get a durable queued row (with superseded tombstones for older queued reviews of the same PR); ping/unroutable deliveries are recorded as ignored:<reason> - a store failure answers 500 so GitHub retries instead of losing work [storage] config with doctor checks; compose gains a data volume; the demo gains an Act 1b proving redelivery dedup end to end (21 assertions); the smoke script covers the missing-delivery-id 400. Worker dispatch still rides the in-process channel in this phase; durable claims, restart recovery, and retirement of the in-memory task store land in phase 2. Signed-off-by: Val Alexander <bunsthedev@gmail.com>
romgenie
pushed a commit
that referenced
this pull request
Jul 8, 2026
…ommand supersession (OpenCoven#13) (OpenCoven#49) Drive-by commenters could steer queued work: the cancel command tombstoned queued reviews at the route (pre-gate), memory acknowledgements replied ungated, and a command review superseded queued reviews at durable insert — all before anyone checked the commander's write access. Now every mutating or acknowledging command lane passes the worker's write gate first: - cancel rides a new adapter-only CancelReviews task; the tombstone happens in the worker after the gate, and below-write commanders get the decline body instead - remember/forget acknowledgements carry the commander and decline below write; status and clarification replies stay ungated - insert-time supersession is auto-review-only: command reviews supersede older queued reviews post-gate via supersede_queued_except, sparing the commanding task itself Re-lands the intent of fix/issue-13-command-gates (pre-durable-store) adapted to the SQLite queue from #2. Signed-off-by: Val Alexander <bunsthedev@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COVEN_REVIEW_FIX_LOOPSfor bounded hosted review repair cycles, clamped from 0 to 5.coven-codewith prior structured findings as explicit repair instructions until findings clear or the configured loop count is exhausted.large_enum_variantwarning in the worker retry enum.Refs #119
Validation
python -B -m py_compile deploy\complete-tech\coven_github_adapter.pycargo fmt --allcargo check --workspacecargo clippy --workspace --all-targets -- -D warningscargo test --workspacegit diff --check(only Windows line-ending warnings)Notes
COVEN_REVIEW_FIX_LOOPSdefaults to0.