Increase maxlength for skill input to 64 characters#579
Closed
aln730 wants to merge 1 commit into
Closed
Conversation
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (0.00% Estimated after merge)
Contributor
Author
|
I didn't merge dev into main because dev currently includes the release.yaml commit |
Contributor
|
you should just merge into dev imo |
Contributor
Author
|
it's already in dev. I just didn't wanna cause any conflicts. |
Contributor
|
oh sick okay, we can do dev -> main imo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Increase maxlength for skill input from 16 to 64
Why
Skills with names longer than 16 characters couldn't be entered. 30 characters seems reasonable.
Test Plan
run locally. ez pz frontend update
Env Vars
N/A
Documentation
N/A
Checklist