chore: remove redundant main.yaml CI workflow by luisina-santos · Pull Request #94 · ConductorOne/baton-gitlab

luisina-santos · 2026-07-16T14:39:43Z

Summary

Removes .github/workflows/main.yaml, which duplicated the go-lint/go-test jobs already covered by ci.yaml, just triggered on push to main instead of pull_request.

Test plan

N/A (workflow file deletion only, no code changes)

🤖 Generated with Claude Code

gontzess · 2026-07-16T14:46:36Z

 name: Test Baton Gitlab Integration

-on: pull_request
+on:


i think you can also remove the go-test and go-lint jobs in this file those should be covered in the verfiy.yaml from baton-admin

Good catch — done in 0b124ae

github-actions · 2026-07-16T14:50:07Z

Connector PR Review: chore: remove redundant main.yaml CI workflow

Blocking Issues: 1 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base f561411df06c.
Review mode: full
View review run

Review Summary

Reviewed the full PR diff (workflow-only changes; no Go source, go.mod, or go.sum touched, so no connector/dependency criteria applied). The PR deletes main.yaml and removes the go-lint/go-test jobs from ci.yaml, adds a push: branches: [main] trigger to ci.yaml, and guards test-cloud-version to pull_request events. The net effect is that golangci-lint and go test no longer run on pull requests or on push to main anywhere in this repo.

Security Issues

None found.

Correctness Issues

.github/workflows/ci.yaml:9 — Removing go-lint/go-test from ci.yaml while deleting main.yaml leaves no workflow running lint or unit tests on pull_request or push to main (other workflows only go build or run on schedule). PR description claims coverage stays in ci.yaml, but this diff removes it.

Suggestions

.github/workflows/ci.yaml:5-7 — The new push: branches: [main] trigger runs no jobs, since the only remaining job (test-cloud-version) is guarded to pull_request only; the push trigger is effectively a no-op.

Prompt for AI agents

Verify each finding against the current code and only fix it if needed.

## Correctness Issues

In .github/workflows/ci.yaml:
- Around line 9 (jobs section): This PR removed the go-lint and go-test jobs from
  ci.yaml and deleted .github/workflows/main.yaml, so no workflow now runs
  golangci-lint or go test on pull requests or on push to main. Confirm whether a
  centralized/reusable workflow covers lint+test; if not, re-add a go-lint and a
  go-test job triggered on pull_request (matching the previous ubuntu/windows
  matrix) so PRs still get linted and unit-tested.

## Suggestions

In .github/workflows/ci.yaml:
- Around lines 5-7 (the added push branches main trigger): the only remaining job
  test-cloud-version is guarded by an if event_name pull_request condition, so the
  push-to-main trigger runs zero jobs. Either add a job that should run on push to main
  or drop the push trigger to avoid a no-op workflow run.

github-actions

No blocking issues found.

github-actions · 2026-07-17T20:59:58Z

+    branches:
+      - main

 jobs:


🟠 Bug: This PR removes the go-lint and go-test jobs from ci.yaml and also deletes main.yaml, which was the only other place those jobs ran. After this change no workflow in the repo runs golangci-lint or go test on pull requests or on push to main — capabilities_and_config.yaml only does go build, and update-dependencies.yaml is a scheduled maintenance job. The PR description says these jobs are "already covered by ci.yaml," but this same diff removes them. Unless a centralized reusable workflow (not present in this repo) runs lint/test, please keep a go-lint/go-test job on pull_request. (confidence: medium-high)

Not a bug — lint/test are covered by the managed verify workflow (baton-admin), which is why @gontzess asked to drop these here. It is not a file in this repo, but verify / lint and verify / test run and pass on this PR, and also run on push to main (confirmed on the latest main commit). So no lint/test coverage is lost by removing the local go-lint/go-test jobs.

github-actions · 2026-07-17T21:00:01Z

+  push:
+    branches:
+      - main


🟡 Suggestion: This adds a push: branches: [main] trigger, but the only remaining job (test-cloud-version) is now guarded by if: github.event_name == 'pull_request', so it is skipped on push. The push-to-main trigger therefore runs zero jobs and is effectively a no-op. If the intent was to run lint/test on push to main (as main.yaml previously did), that coverage is now missing. (confidence: high)

Good catch — fixed in 9905983. Since verify already covers lint/test on push to main, the push: [main] trigger here only pointed at the PR-only test-cloud-version job (zero jobs on push). Switched to on: pull_request and dropped the now-redundant if: github.event_name == 'pull_request' guard.

github-actions

Blocking issues found — see review comments.

github-actions · 2026-07-20T19:51:47Z

@@ -3,45 +3,6 @@ name: Test Baton Gitlab Integration
 on: pull_request

 jobs:


🟠 Bug: This PR removes the go-lint and go-test jobs from ci.yaml in addition to deleting main.yaml. After merge, no workflow runs golangci-lint or go test on pull_request or push to main (the other workflows only go build or run integration tests needing secrets). The PR describes main.yaml as a redundant duplicate of jobs "already covered by ci.yaml," but this diff also deletes those jobs from ci.yaml, so lint/unit-test coverage is eliminated rather than deduplicated. If deduplication was the intent, keep go-lint/go-test in ci.yaml and only delete main.yaml.

github-actions · 2026-07-20T19:54:05Z

Connector PR Review: chore: remove redundant main.yaml CI workflow

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base f67c5e816c9c.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness. Beyond the CI workflow cleanup, this PR also migrates deprecated SDK trait options (WithGroupProfile/WithUserProfile/WithStatus) to the resource-level WithResourceProfile/WithResourceStatus in groups.go, projects.go, and users.go; that migration is correct — the trait is still created via the (now empty) trait-option slices, and the new ResourceOption signatures match the vendored SDK. The go-test job remains and runs on both pull_request and push to main, so the earlier concern about lost test coverage and a no-op push trigger does not apply. One suggestion remains regarding lint coverage.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

.github/workflows/ci.yaml:10 — Removing the go-lint job here plus deleting main.yaml leaves no workflow running golangci-lint on PRs or push to main; verify the shared verify.yaml@v4 covers lint, otherwise keep one lint job.

Prompt for AI agents

Verify each finding against the current code and only fix it if needed.

## Suggestions

In .github/workflows/ci.yaml:
- Around line 10: This PR removed the go-lint job from ci.yaml and deleted
  .github/workflows/main.yaml, which also ran golangci-lint. No remaining workflow
  runs golangci-lint on pull_request or push to main. First confirm whether the shared
  reusable workflow referenced by .github/workflows/verify.yaml
  (ConductorOne/github-workflows/.github/workflows/verify.yaml@v4) runs golangci-lint.
  If it does not, restore a single go-lint job in ci.yaml (using
  golangci/golangci-lint-action) so lint coverage is preserved on PRs and pushes to main.

github-actions

Blocking issues found — see review comments.

already fixed

main.yaml duplicated the go-lint/go-test jobs already covered by ci.yaml, just triggered on push to main instead of pull_request. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

main.yaml previously ran go-lint/go-test on push to main; now that it's removed, ci.yaml picks up that trigger directly. test-cloud-version stays PR-only since it hits the real GitLab API and wasn't part of main.yaml's scope. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Migrate WithGroupProfile/WithUserProfile/WithStatus (deprecated, SA1019) to the resource-level WithResourceProfile/WithResourceStatus options in groups.go, projects.go, and users.go. Remove the redundant go-lint job from the "Test Baton Gitlab Integration" workflow; verify.yaml's `verify / lint` already covers it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

github-actions · 2026-07-21T19:17:59Z

-          version: latest
-          args: --timeout=3m
-
  go-test:


🟡 Suggestion: This PR removes the go-lint job from ci.yaml and deletes main.yaml (which also ran golangci-lint), leaving no workflow that runs golangci-lint on PRs or pushes to main. The commit intent was to deduplicate the lint job, but it's now eliminated entirely rather than kept in one place. Unless the shared verify.yaml@v4 reusable workflow runs lint, consider keeping a single go-lint job here. (medium confidence — depends on what the shared verify workflow covers)

github-actions

No blocking issues found.

luisina-santos requested a review from a team July 16, 2026 14:39

gontzess reviewed Jul 16, 2026

View reviewed changes

github-actions Bot reviewed Jul 16, 2026

View reviewed changes

mateoHernandez123 approved these changes Jul 17, 2026

View reviewed changes

mateoHernandez123 mentioned this pull request Jul 17, 2026

Remove redundant main.yaml CI workflow (fixes covdata failure on main) - GitLab Connector #95

Closed

1 task

mateoHernandez123 requested a review from gontzess July 17, 2026 20:57

mateoHernandez123 assigned btipling, johnallers and gontzess Jul 17, 2026

mateoHernandez123 requested review from btipling and johnallers July 17, 2026 20:59

github-actions Bot reviewed Jul 17, 2026

View reviewed changes

github-actions Bot requested changes Jul 17, 2026

View reviewed changes

github-actions Bot reviewed Jul 20, 2026

View reviewed changes

github-actions Bot previously requested changes Jul 20, 2026

View reviewed changes

Bencheng21 approved these changes Jul 20, 2026

View reviewed changes

btipling approved these changes Jul 20, 2026

View reviewed changes

btipling removed their assignment Jul 20, 2026

luisina-santos and others added 2 commits July 21, 2026 13:04

chore: remove redundant main.yaml CI workflow

25a3f2a

main.yaml duplicated the go-lint/go-test jobs already covered by ci.yaml, just triggered on push to main instead of pull_request. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

luisina-santos force-pushed the luisinasantos/remove-main-yaml-workflow branch from 9905983 to 1a59dc5 Compare July 21, 2026 16:05

github-actions Bot reviewed Jul 21, 2026

View reviewed changes

luisina-santos merged commit 7243339 into main Jul 21, 2026
11 checks passed

luisina-santos deleted the luisinasantos/remove-main-yaml-workflow branch July 21, 2026 20:19

		@@ -3,45 +3,6 @@ name: Test Baton Gitlab Integration
		on: pull_request

		jobs:

Uh oh!

Conversation

luisina-santos commented Jul 16, 2026

Summary

Test plan

Uh oh!

gontzess Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

mateoHernandez123 Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Connector PR Review: chore: remove redundant main.yaml CI workflow

Review Summary

Security Issues

Correctness Issues

Suggestions

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

luisina-santos Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

luisina-santos Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Connector PR Review: chore: remove redundant main.yaml CI workflow

Review Summary

Security Issues

Correctness Issues

Suggestions

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mateoHernandez123 Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 16, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading