Skip to content

๐Ÿงน refactor(ci): extract parse_args from main in materialize scripts #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

๐Ÿงน refactor(ci): extract parse_args from main in materialize scripts #843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions scripts/ci/materialize_base_javascript_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,14 +424,19 @@ def materialize(
return manifest


def main(argv: list[str] | None = None) -> int:
"""Materialize trusted JavaScript locks and report their exact revisions."""
def parse_args(argv: list[str] | None = None) -> argparse.Namespace:
"""Parse command-line arguments."""
parser = argparse.ArgumentParser()
parser.add_argument("--repo-root", required=True, type=pathlib.Path)
parser.add_argument("--base-sha", required=True)
parser.add_argument("--head-sha")
parser.add_argument("--output-dir", required=True, type=pathlib.Path)
args = parser.parse_args(argv)
return parser.parse_args(argv)


def main(argv: list[str] | None = None) -> int:
"""Materialize trusted JavaScript locks and report their exact revisions."""
args = parse_args(argv)

try:
manifest = materialize(
Expand Down
Loading