Skip to content

🧹 [μ½”λ“œ ν—¬μŠ€ κ°œμ„ ] validate_candidate ν•¨μˆ˜ λ¦¬νŒ©ν† λ§ #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonghobae wants to merge 3 commits into
base: main
Choose a base branch
from
+14 βˆ’24
Open

🧹 [μ½”λ“œ ν—¬μŠ€ κ°œμ„ ] validate_candidate ν•¨μˆ˜ λ¦¬νŒ©ν† λ§ #887

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
172154e
🧹 [μ½”λ“œ ν—¬μŠ€ κ°œμ„ ] validate_candidate ν•¨μˆ˜ λ¦¬νŒ©ν† λ§
seonghobae Aug 9, 2026
2733ac7
🧹 [μ½”λ“œ ν—¬μŠ€ κ°œμ„ ] validate_candidate ν•¨μˆ˜ λ¦¬νŒ©ν† λ§
seonghobae Aug 9, 2026
f5da593
🧹 [μ½”λ“œ ν—¬μŠ€ κ°œμ„ ] validate_candidate ν•¨μˆ˜ λ¦¬νŒ©ν† λ§
seonghobae Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 14 additions & 24 deletions scripts/ci/assert_opencode_reasoning_effort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,39 +47,29 @@ def validate_candidate(config: dict[str, Any], candidate: str) -> list[str]:
except ValueError as exc:
return [str(exc)]

if not config_for_model and (
provider == "github-models" or is_known_reasoning_capable(model_name)
):
return [
f"OpenCode candidate {candidate} is not defined in opencode.jsonc "
f"under provider {provider}."
]
if not config_for_model:
if provider == "github-models" or is_known_reasoning_capable(model_name):
return [
f"OpenCode candidate {candidate} is not defined in opencode.jsonc "
f"under provider {provider}."
]
return []

configured_reasoning = config_for_model.get("reasoning") is True
should_require_effort = configured_reasoning or is_known_reasoning_capable(model_name)
if not should_require_effort:
if not (configured_reasoning or is_known_reasoning_capable(model_name)):
return []

errors: list[str] = []
prefix = f"OpenCode reasoning-capable candidate {candidate} must set"
suffix = "in opencode.jsonc."

if not configured_reasoning:
errors.append(
f"OpenCode reasoning-capable candidate {candidate} must set reasoning=true "
"in opencode.jsonc."
)
errors.append(f"{prefix} reasoning=true {suffix}")
if (config_for_model.get("options") or {}).get("reasoningEffort") != "high":
errors.append(
f"OpenCode reasoning-capable candidate {candidate} must set "
"options.reasoningEffort=high in opencode.jsonc."
)
if ((config_for_model.get("variants") or {}).get("high") or {}).get(
"reasoningEffort"
) != "high":
errors.append(
f"OpenCode reasoning-capable candidate {candidate} must set "
"variants.high.reasoningEffort=high in opencode.jsonc."
)
errors.append(f"{prefix} options.reasoningEffort=high {suffix}")
if ((config_for_model.get("variants") or {}).get("high") or {}).get("reasoningEffort") != "high":
errors.append(f"{prefix} variants.high.reasoningEffort=high {suffix}")

return errors


Expand Down
Loading