Skip to content

fix(opencode): include adversarial gate in fallback scope - #904

Open
seonghobae wants to merge 1 commit into
mainfrom
fix/opencode-adversarial-fallback-scope-current-main-20260809
Open

fix(opencode): include adversarial gate in fallback scope#904
seonghobae wants to merge 1 commit into
mainfrom
fix/opencode-adversarial-fallback-scope-current-main-20260809

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • add the extracted adversarial-evidence gate and its existing test twin to the central review-process fallback scope;
  • add a permanent contract proving both exact paths remain in the bounded allowlist;
  • preserve the existing core-file classifier, 24-file cap, provider budgets, credentials, model selection, review authority, and merge policy.

RCA and feasibility

The observed symptom is CENTRAL_REVIEW_PROCESS_FALLBACK_ELIGIBLE=false when a central review-process change touches the extracted adversarial-evidence gate. The immediate cause is two missing path cases. The root cause is refactor drift: the gate moved out of an already-allowlisted normalizer after the allowlist was established.

The smallest root-cause repair is to allowlist exactly the production module and its existing test. Duplicating the gate, broadening to a directory wildcard, increasing the file cap, or weakening the fallback check would enlarge the trust boundary and was rejected. No open PR or active writer owned issue #626 at publication time.

Test-first evidence

  • RED: a direct contract probe failed on protected main because the production path was absent;
  • GREEN: the exact two-path allowlist contract passes;
  • the modified test module compiles;
  • both target files exist and the production module still exposes adversarial_evidence_rejection_reason;
  • git diff --check passes.

Exact-head CI, security, current automated review, qualifying independent approval, and protected-main evidence remain required before operational closure.

Fixes #626

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fe09c2e1-0c0d-4cf5-98cf-c4d95b19061c

📥 Commits

Reviewing files that changed from the base of the PR and between 6eb06cd and f9db98f.

📒 Files selected for processing (2)
  • .github/workflows/opencode-review-dispatch.yml
  • tests/test_opencode_agent_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) August 9, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Central review-process fallback allowlist drift: adversarial_evidence.py missing since #555 extraction

1 participant