fix(sandbox): replay redaction after fixture-history contamination - #906
Draft
seonghobae wants to merge 10 commits into
Draft
fix(sandbox): replay redaction after fixture-history contamination#906seonghobae wants to merge 10 commits into
seonghobae wants to merge 10 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement purpose
Supersede #888 after its reachable history was re-contaminated by a credential-shaped test fixture while repairing the current Docker/Podman login redaction defect. This branch starts from exact protected
main@6eb06cdd08c79a06f7b390069d4ffa49e2eb7dbaand carries only the corrected final blobs.RCA
#888 initially existed to replace #842's contaminated test history. A later test commit on #888 introduced the fixed literal
quartz-capybara-731-opaque. Replacing that line in a following commit did not repair the gate because Secret Scan correctly evaluates the whole PR commit range; run 31319880976 continued to report onegeneric-api-keyfinding in the reachable predecessor commit.Rejected:
Implemented:
Exact identity
6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba;5ccf85f64c4a5689d89e64b528880262a22e6de7;285305291fdf602f31796f0c7ff1c2858406c08e;Exact-head evidence
5ccf85f64c4a5689d89e64b528880262a22e6de7;6eb06cdd..5ccf85fand reported zero Gitleaks findings;Current security scope
This replay includes the focused Docker/Podman
login -p,-p=, and--password=redaction repair while preserving benign Docker publish ports and SSH-pports.It does not claim the broader blocker is closed. Bounded wrapper recursion for
env -Sand shell-coperands is tracked by #907; atomic multiline/duplicate-key JSON redaction and layout fidelity is tracked by #908. Keep this PR Draft until those gaps or an explicitly reviewed narrower acceptance boundary are resolved. Output-memory and service-file quotas remain separate work in #766.Acceptance
Require exact-head Sandbox Log Redaction Quality CI, Secret Scan, all security/dependency checks, current source review, zero valid unresolved findings, a qualifying independent non-author formal approval, and repository protection. After protected integration, run synthetic protected-main acceptance for completed stdout/stderr, timeout evidence, and bounded service tails before closing the incident.