fix(core): revalidate semantic action against current observation - #102
Draft
seonghobae wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on exact PR #101 head
bd75a43ddcd0a7afa4f032ecc2b930d742c3ece5.Buyer/correctness gap
PR #101 prevents construction of an interactive semantic-node target from an observation already known to be disabled, but the resulting target can still outlive a later same-document semantic change. Before a trusted adapter uses that target, OriginWeave needs a bounded way to compare it with a freshly observed semantic node so a removed action, newly disabled state, or different node cannot silently reuse the old target.
Dependency
This Draft targets PR #101 branch
fix/semantic-node-disabled-actionand must remain Draft while #101/#96/#95/#93/#58/#57/#52/#40 remain active. No prerequisite check, review, status, mergeability, or coverage evidence transfers.TDD / implementation
992c346af20ee1882e03b8c7237a1f3d34b75c83requiredSemanticNodeActionTarget::validate_current_observationto accept only the same exact node with the selected action still advertised and its current enabled-state contract still satisfied.ObservationAuthorityMismatch; a removed action remainsUnsupportedAction; a newly disabled interactive node remainsNodeNotEnabled; and non-enabledScrollIntoViewremains valid.c751865412d5642357203f917f16c6c2bbd12324also includes the focused regression coverage required by that public boundary.Exact-head proof
On unchanged exact head
c751865412d5642357203f917f16c6c2bbd12324against unchanged exact prerequisite #101 headbd75a43ddcd0a7afa4f032ecc2b930d742c3ece5:31554288115: success, including repository contracts, canonical formatting, locked workspace/all-target check, full tests, strict Clippy, rustdoc, and exact owned production function/line/region/branch coverage;31554288335: success;No predecessor-head or prerequisite result is transferred.
Truth boundary
This pure core slice does not observe Chromium, authenticate an adapter, decide when a DOM/AX mutation requires re-observation, rotate epochs, authorize policy, dispatch input, or prove a post-condition. A trusted runtime must supply the current bounded observation immediately before use; this method only prevents that newly observed state from being ignored after an older target was created.