test(browser): bind controlled result to semantic digest evidence - #105
Draft
seonghobae wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on exact PR #100 head
13f49b7fc4f11d0fd851f51d816dc0cc94003b91.Buyer-visible gap
The pinned-Chromium Agent Task already discovers the input and submit action by exact browser-computed role/name, but its post-condition result was still retrieved by fixture CSS and represented only as boolean success. The controlled workflow therefore lacked a bounded structured extraction artifact that can later compose with OriginWeave's typed source-node/network provenance boundary.
Dependency
This Draft targets PR #100 branch
test/agent-task-semantic-role-name-locatorat unchanged exact head13f49b7fc4f11d0fd851f51d816dc0cc94003b91. Keep Draft while #100 and its browser-evidence prerequisites remain active. No prerequisite check, review, status, artifact, or mergeability result transfers.TDD / RCA sequence
3eaf34bd1d146dd69351799c5812c07c7b3eb7f1required the result node to carry an explicit accessible name, be discovered through exact browser-computedstatus/Task resultsemantics rather than#task-result, and produce bounded credential-safe structured-value evidence.31559008579, Rust contracts job93997236182, checked out that exact test-only head and failed at the intended Python repository-contract boundary with five missing-contract failures: absent result accessible name, absentMAX_AGENT_TASK_STRUCTURED_VALUE_BYTES, absent_hash_agent_task_structured_value, and absent result-semantic/structured-value evidence fields. This is the valid RED.d2e4086127922a96f12ca4fca7b4eef602f4020cadded the explicitTask resultaccessible name.6800ef029da0be98eac3699872b8ef0cc0856de0added the smallest runner implementation: exact semantic result discovery, a 4096-byte UTF-8 extraction bound, canonical lowercase SHA-256 evidence, stabletask_resultfield identity, and no raw extracted value in emitted evidence.bc1d22d6c4848a173c55fdd18054574299488067adds only the truthful Unreleased changelog entry describing that implemented boundary.Exact-current proof
On unchanged exact current head
bc1d22d6c4848a173c55fdd18054574299488067against unchanged exact prerequisite #100 head13f49b7fc4f11d0fd851f51d816dc0cc94003b91:31559777436: success;93999549329: success, including Python repository contracts, canonical formatting, locked workspace/all-target check, full tests, strict Clippy and rustdoc;93999549280: success, including exact owned production function/line/region/branch enforcement;31559777419: success against Chrome for Testing150.0.7871.129/ revisionr1639810;mv3-compatibility-bc1d22d6c4848a173c55fdd18054574299488067, artifact ID9127308443, archive digestsha256:68070752879b61a4a1c4f3b49a7edd25e7180594a6bf1a9ce46047b6008ea577;3/3, pass rate1.0; every trial reportsresult_semantics_verified=true,structured_value_field=task_result, and digestsha256:3f9d88d8df56ef344ef37877e568494065c2be33870053e5ad722de0367a3be5;originweave controlled inputis absent from emitted JSON evidence;CodeRabbit's current draft status is not treated as independent review evidence. No predecessor-head proof is transferred to the current head.
Implemented boundary
The controlled result is now found by exact browser-computed
status/Task resultsemantics, its exact synthetic text is checked transiently only to prove the deterministic post-condition, and the emitted trial evidence retains only a stable field identifier plus a bounded canonical SHA-256 digest. Empty, oversized, or non-text structured values fail closed at the hashing boundary.Truth boundary
This is executable pinned-browser compatibility evidence, not the production browser adapter and not complete source/network provenance. It does not mint an OriginWeave node handle, authenticate a browser adapter, authorize an action, capture or retain raw network payloads, bind the digest to independently verified
ProvenanceRecordinstances, persist the extracted value, or claim the complete issue #28 chain. PR #104 independently defines the typed structured-value/node/network provenance composition contract on another active stack; this lane does not duplicate or promote that active-PR behavior to protected-main truth.