test(browser): constrain semantic observation evidence schema - #129
Draft
seonghobae wants to merge 3 commits into
Draft
test(browser): constrain semantic observation evidence schema#129seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on unchanged exact PR #128 head
24446c9cacd05bab370d8a636552514d656fcf42.Buyer/security gap
PR #128 bounds the controlled Agent Task semantic-observation bytes, but byte size alone does not constrain evidence meaning. A later runner change could add unreviewed raw page text, hidden prompt-injection content, or arbitrary instruction-like fields while remaining under 4,096 bytes. The controlled compatibility lane therefore needs an exact reviewed evidence-schema contract at the executable construction site without pretending that the generic byte-measurement helper is a semantic validator.
Dependency
This Draft targets unchanged exact #128 head
24446c9cacd05bab370d8a636552514d656fcf42and must remain Draft while #128/#105/#100 and their prerequisites remain active. PR #132 and its descendants already depend on this exact head, so ancestry must be preserved. No prerequisite check, review, status, artifact, coverage, mergeability, or synthetic-merge result transfers.TDD and RCA sequence
5791b650ccd7f1f9c40ea49ed565fc051d9f018dinitially required the generic_measure_agent_task_semantic_observation_byteshelper to reject extra or malformed fields. CI run31625916343, Rust contracts job94212118955, failed in Python repository contracts as expected.46efc3d530494b41f84c25ae50bc8fd1e623e027moved the fail-closed contract to the actual executablesemantic_observationconstruction. The AST-level repository test requires one exact construction and one exact bounded-helper call.d199a0d1f30746aafc67986bf9dbc3ca88d802c6adds only the truthful Unreleased security changelog entry.Implemented contract
The repository contract parses the controlled runner AST and now requires:
semantic_observationassignment in the executable Agent Task path;inputandsubmit;roleandname;input_role,input_name,submit_role, andsubmit_namevariables;_measure_agent_task_semantic_observation_bytes(semantic_observation)call;The byte helper remains separately responsible only for canonical compact UTF-8 serialization and the finite 4,096-byte ceiling.
Exact-head proof
On unchanged exact head
d199a0d1f30746aafc67986bf9dbc3ca88d802c6against unchanged exact prerequisite24446c9cacd05bab370d8a636552514d656fcf42:31626768646: success;94215037538: repository contracts, canonical formatting, locked workspace/all-target check, full tests, strict Clippy, and rustdoc success;94215037655: exact owned production function/line/region/branch enforcement success;No predecessor-head or prerequisite evidence is promoted as current proof.
Truth boundary
This lane hardens only the controlled pinned-browser compatibility evidence shape. It does not define the final product-wide semantic observation schema, authenticate browser semantics, make accessible names trusted instructions, authorize model context, expose raw HTML, grant capabilities, inspect all browser channels, or complete the end-to-end browser adapter. A trusted production adapter still needs versioned structured-observation contracts and immediate authority checks at its real browser boundary.