test(browser): require Agent Task browser-process termination evidence - #142
Draft
seonghobae wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on exact current PR #141 head
42af52f77336112c4fbe1da5c5283899f6bd288e.Buyer/reliability gap
The controlled pinned-Chromium Agent Task proved temporary-profile teardown, bounded process/RSS sampling, and WebDriver session cleanup, but did not prove that the original browser root process actually terminated. A surviving browser process can retain task state or resources after its temporary profile path has been removed.
Dependency
This Draft targets exact current #141 head
42af52f77336112c4fbe1da5c5283899f6bd288eand must remain Draft while its prerequisite stack remains active. No prerequisite check, review, status, coverage, mergeability, synthetic-merge, predecessor-head, skipped, cancelled, queued, or absent evidence transfers.TDD and implementation sequence
146f742b140b54577b1e349be9c4a815fd6691d9required PID/start-time identity binding through bounded Linux/proc/<pid>/statparsing and post-shutdown process termination evidence. CI31660930985, Rust contracts job94325412054, failed first at the Python repository-contract boundary because production support was intentionally absent.52b6ca22a1edf3367cb8ca4adc82c9e91f4233d6.b9201c8176d15f2bc5d9d2fbdc4577a580c2828dhardened malformed/proc/<pid>/statsuffix rejection.a66fb27532a689e2e2458c7ff3cb79b340d113ceadds the truthful changelog record for the implemented boundary.Implemented contract
The runner now:
browser_process_terminated: truein successful controlled Agent Task evidence only after browser/driver shutdown proves that exact identity has ended.Current exact-head proof
On
a66fb27532a689e2e2458c7ff3cb79b340d113ceagainst exact base42af52f77336112c4fbe1da5c5283899f6bd288e:31666834834: completed successfully;31666834858: completed successfully;Truth boundary
This lane proves the exact Chrome root process identified by ChromeDriver for the controlled Agent Task path. Descendant-process-set teardown and later failure-path preservation are separate descendant lanes. It does not prove OS-wide orphan absence, cgroup/task ownership, cross-platform process supervision, Chromium/ChromeDriver provenance, or completion of #28.