test: preserve late-failure teardown evidence - #145
Draft
seonghobae wants to merge 6 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial #28. Stacked on current PR #144 exact head
fea7bec6a3ef3f378884b717d36028d9103bde92. Current exact head is5ee76849a1dc22f10ddcd291c8bac4cd612fa6a1.Late-failure teardown TDD
f65d1ba45939605d577203e2bb1d1b3f183fbba1: CI31680812328/ Rust contracts job94385604530failed at the new late-failure process-set teardown contract while production still returned only browser-root termination evidence.69b43c004c7c93419069bff472eac6b50d0ef97cmoved sampled Chromium process-set shutdown verification before the failure return and propagated optional teardown evidence through the trial result.77baa9581596dd2b195afb03182c5c730a704685removed an irrelevant dict-shape coupling while retaining the behavioral contracts for preserving a sampled-setFalseresult and omitting process-set evidence when identities were never captured.Current branch boundary
After that late-failure slice, this same branch also gained the forced-close process-termination foundation now used as the exact prerequisite for PR #146. The current delta therefore includes the controlled forced-close process-termination contract and runner support in addition to the original late-failure evidence preservation. PR #146 remains the descendant lane for retaining that forced-close teardown evidence through its reviewed failure envelope; no descendant behavior is promoted into this PR by inference.
Current exact-head proof at
5ee76849a1dc22f10ddcd291c8bac4cd612fa6a1:31692576373: success;31692576338: success;Truth boundary
When a controlled Agent Task fails after the bounded Chromium root-plus-descendant PID/start-time identities have been captured, shutdown waits for and preserves that exact sampled process-set termination outcome as well as browser-root termination. Failures before process-set capture do not invent descendant evidence. The additional forced-close foundation remains bounded Linux
/procPID/start-time evidence. None of this attests cgroup/task ownership, processes created only after sampling, cross-platform teardown, or OS-wide orphan absence.This PR remains Draft behind its dependency stack and does not transfer prerequisite, descendant, review, or merge authority.