feat(sensitive): revoke authoritative handle use state - #53
Draft
seonghobae wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #10.
Buyer/security gap
The stacked prerequisite #46 makes use counts authoritative inside
SensitiveHandleUseState, but issue #10 also requires handle revocation on task completion, policy change, key rotation, session termination, or suspicious use. Without authoritative revocation state, a still-unexpired handle with remaining uses can continue to reserve disclosures after the broker has determined it must be withdrawn.TDD evidence
This draft is stacked on exact #46 head
5f212cdfbf3c453472069973138fd9563cf7bff8.RED was established at exact test-only head
219bfdc95facadfe034a371badc14326e169c627: repository contracts and rustfmt passed, thencargo check --locked --workspace --all-targetsfailed because the public production boundary did not yet provideHandleRevocationReason,SensitiveHandleUseState::revoke,SensitiveHandleUseState::revocation_reason, orHandleUseDecision::Revoked.Current exact head
86ce4bc1c11c270dc532593d673c42bd6f623d74now provides:Revokeddenial before future use reservation;Exact-head CI is GREEN: repository contracts, rustfmt, locked workspace check, full tests, strict Clippy, rustdoc, and exact production function/line/region/branch coverage all pass. CodeRabbit commit status is also successful. No inline review threads are currently open.
Scope boundary
This remains an in-process policy-state primitive. It adds no opaque token storage, protected value storage/resolution, database persistence, cross-process transactionality, encryption/KMS, model disclosure, browser fill, workflow mutation, or release claim.
Keep Draft while prerequisite #46 remains active. Canonical whole-product documentation remains owned by PR #44 and this active PR must not be described as protected-main shipped truth.